Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restructure code and add test cases #1329

Merged
merged 15 commits into from
Sep 20, 2024

Conversation

hetangmodi-crest
Copy link
Contributor

Issue number: ADDON-73368

Summary

Changes

Restructuring of code - moving helper functions in utils.py and cleaning up duplicate code present elsewhere.

User experience

No change, the build process would work as it did before.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

@hetangmodi-crest hetangmodi-crest self-assigned this Aug 30, 2024
@hetangmodi-crest
Copy link
Contributor Author

hetangmodi-crest commented Aug 30, 2024

Note: to be reviewed and merged after PR #1328 is merged.

splunk_add_on_ucc_framework/utils.py Show resolved Hide resolved
splunk_add_on_ucc_framework/utils.py Outdated Show resolved Hide resolved
splunk_add_on_ucc_framework/utils.py Outdated Show resolved Hide resolved
lplonka-splunk
lplonka-splunk previously approved these changes Sep 19, 2024
hetangmodi-crest and others added 14 commits September 20, 2024 12:47
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[splunk/appinspect-cli-action](https://togithub.com/splunk/appinspect-cli-action)
| action | minor | `v2.7` -> `v2.8` |

---

### Release Notes

<details>
<summary>splunk/appinspect-cli-action
(splunk/appinspect-cli-action)</summary>

###
[`v2.8`](https://togithub.com/splunk/appinspect-cli-action/compare/v2.7...v2.8)

[Compare
Source](https://togithub.com/splunk/appinspect-cli-action/compare/v2.7...v2.8)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every 2 weeks on Sunday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/splunk/addonfactory-ucc-generator).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
**Issue number:** -

## Summary

### Changes

> Fixed the indentation of unordered list used in the docs.

### User experience

> No change, only the documentation would be changed, made prettier.

## Checklist

If your change doesn't seem to apply, please leave them unchecked.

* [ ] I have performed a self-review of this change
* [ ] Changes have been tested
* [x] Changes are documented
* [x] PR title follows [conventional commit
semantics](https://www.conventionalcommits.org/en/v1.0.0/)

Co-authored-by: Artem Rys <[email protected]>
…oard (#1337)

**Issue number:
[ADDON-74234](https://splunk.atlassian.net/browse/ADDON-74234)**

## Summary

Added possibility to display messages logged with CRITICAL level in the
error section in the monitoring dashboard.

### Changes

Global config -> dashboard has a new setting: `error_panel_log_lvl`,
which allows the user to define what log level should be displayed in
the errors section of the monitoring panel

### User experience

The user can define error log lvl in the global config. By default only
ERROR

## Checklist

If your change doesn't seem to apply, please leave them unchecked.

* [x] I have performed a self-review of this change
* [x] Changes have been tested
* [x] Changes are documented
* [x] PR title follows [conventional commit
semantics](https://www.conventionalcommits.org/en/v1.0.0/)

---------

Co-authored-by: Artem Rys <[email protected]>
@hetangmodi-crest hetangmodi-crest merged commit 7ce9ecf into develop Sep 20, 2024
77 checks passed
@hetangmodi-crest hetangmodi-crest deleted the chore/restructure-code-test-case branch September 20, 2024 08:48
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants