Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title fields use headings #164

Merged
merged 3 commits into from
May 11, 2015
Merged

Title fields use headings #164

merged 3 commits into from
May 11, 2015

Conversation

micgro42
Copy link
Collaborator

This pull request replaces #163

This pul request fixes multiple issues:

  • The title fields were not respecting the useHeading conf option
  • A value entered for page or data field may be linked as relative, but they are always looked-up absolute and hence should always be treated as such
  • This also fixes the issue that the %pageid% shown in datatable was occasionally wrong, when dataentry was in the root namespace, but datatable was not

@micgro42
Respect $conf[useheading] for title fields w/o title
b6306a3 
Also add tests for fields of the type page, title, and pageid
@micgro42
Test database lookups for _title fields
05d8102
@micgro42
Values for page and title are always absolute
15b9cc3 
_resolveData always resolves the id from title and page fields starting
from the root namespace, since it doesn't know about the namespace of
the corresponding dataentry. Hence the dataentry dialog should always
consider the entered ids to be absolute and link them accordingly.
splitbrain added a commit that referenced this pull request May 11, 2015
@splitbrain
Merge pull request #164 from micgro42/TitleFieldsUseHeadings
92dd1f9 
Title fields use headings
@splitbrain splitbrain merged commit 92dd1f9 into splitbrain:master May 11, 2015
@micgro42 micgro42 deleted the TitleFieldsUseHeadings branch October 24, 2016 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micgro42 @splitbrain