Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #5 Cannot delete namespace permission from scabbard CLI #6

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fixes #5 Cannot delete namespace permission from scabbard CLI #6

merged 1 commit into from
Feb 7, 2024

Conversation

rohitmp
Copy link
Contributor

@rohitmp rohitmp commented Feb 6, 2024

  1. removed the conflict with contract name from cli param.
  2. added contract_name when DeleteNamespaceRegistryPermissionAction is built using the DeleteNamespaceRegistryPermissionActionBuilder

@agunde406 agunde406 self-assigned this Feb 7, 2024
@agunde406 agunde406 mentioned this pull request Feb 7, 2024
Merged
@agunde406 agunde406 merged commit 42d6dda into splintercommunity:main Feb 7, 2024
5 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agunde406 agunde406 agunde406 approved these changes

@jsmitchell jsmitchell Awaiting requested review from jsmitchell jsmitchell is a code owner

@peterschwarz peterschwarz Awaiting requested review from peterschwarz peterschwarz is a code owner

@vaporos vaporos Awaiting requested review from vaporos vaporos is a code owner

Assignees

@agunde406 agunde406

Labels
backport-triage main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohitmp @agunde406