Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade FSST #2674

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Upgrade FSST #2674

merged 1 commit into from
Mar 12, 2025

Conversation

gatesn
Copy link
Contributor

@gatesn gatesn commented Mar 12, 2025

No description provided.

@gatesn gatesn enabled auto-merge (squash) March 12, 2025 14:42
@gatesn gatesn added the benchmark Run benchmarks on this branch label Mar 12, 2025
@github-actions github-actions bot removed the benchmark Run benchmarks on this branch label Mar 12, 2025
Copy link

codspeed-hq bot commented Mar 12, 2025

CodSpeed Performance Report

Merging #2674 will degrade performances by 11.13%

Comparing ngates/bump-fsst (6c8406a) with develop (183c831)

Summary

❌ 2 regressions
✅ 773 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
chunked_canonicalize_into[(1000, 50, 8, 64)] 6.7 ms 7.5 ms -11.13%
chunked_into_canonical[(1000, 50, 8, 64)] 6.7 ms 7.6 ms -11.07%

Copy link
Contributor

Benchmarks: TPC-H on NVME

Table of Results
name PR 01f0b84 base 183c831 ratio (PR/base) unit
tpch_q01/arrow 41965951 46064968 0.911017 ns
tpch_q02/arrow 50827087 49163906 1.03383 ns
tpch_q03/arrow 30666029 32397444 0.946557 ns
tpch_q04/arrow 22731934 22777559 0.997997 ns
tpch_q05/arrow 47700624 51060159 0.934204 ns
tpch_q06/arrow 9127664 10677673 0.854836 ns
tpch_q07/arrow 74578243 78056131 0.955444 ns
tpch_q08/arrow 56082665 59889016 0.936443 ns
tpch_q09/arrow 71002805 72393504 0.98079 ns
tpch_q10/arrow 45542904 46659466 0.97607 ns
tpch_q11/arrow 24434269 25329832 0.964644 ns
tpch_q12/arrow 28374088 27774980 1.02157 ns
tpch_q13/arrow 16422598 17529353 0.936863 ns
tpch_q14/arrow 15388020 14263260 1.07886 ns
tpch_q15/arrow 27057028 27250912 0.992885 ns
tpch_q16/arrow 22120462 22845027 0.968283 ns
tpch_q17/arrow 61323210 62336360 0.983747 ns
tpch_q18/arrow 94323323 100958708 0.934276 ns
tpch_q19/arrow 27437609 29595248 0.927095 ns
tpch_q20/arrow 34213977 36672009 0.932973 ns
tpch_q21/arrow 113392187 119224167 0.951084 ns
tpch_q22/arrow 15730612 15928896 0.987552 ns
tpch_q01/parquet 115095004 125755655 0.915227 ns
tpch_q02/parquet 117548703 119596049 0.982881 ns
tpch_q03/parquet 109452893 115191156 0.950185 ns
tpch_q04/parquet 61361255 65102595 0.942532 ns
tpch_q05/parquet 118253018 122416073 0.965993 ns
tpch_q06/parquet 26126042 28704951 0.910158 ns
tpch_q07/parquet 134824890 144467649 0.933253 ns
tpch_q08/parquet 161420030 170598388 0.946199 ns
tpch_q09/parquet 210726202 224940087 0.93681 ns
tpch_q10/parquet 128945400 143076147 0.901236 ns
tpch_q11/parquet 56620486 59355703 0.953918 ns
tpch_q12/parquet 103280706 98368620 1.04994 ns
tpch_q13/parquet 151551206 158753859 0.95463 ns
tpch_q14/parquet 45708322 47599136 0.960276 ns
tpch_q15/parquet 65483700 71479115 0.916124 ns
tpch_q16/parquet 51456926 53600249 0.960013 ns
tpch_q17/parquet 131734445 137587111 0.957462 ns
tpch_q18/parquet 185745283 211120230 0.879808 ns
tpch_q19/parquet 75241561 79560812 0.945711 ns
tpch_q20/parquet 97438254 103382332 0.942504 ns
tpch_q21/parquet 186649645 192617870 0.969015 ns
tpch_q22/parquet 49970741 53715376 0.930287 ns
tpch_q01/vortex-file-compressed 36746326 38719176 0.949047 ns
tpch_q02/vortex-file-compressed 62965702 64593590 0.974798 ns
tpch_q03/vortex-file-compressed 34747595 34630578 1.00338 ns
tpch_q04/vortex-file-compressed 19619638 22488799 0.872418 ns
tpch_q05/vortex-file-compressed 49608756 50442808 0.983465 ns
tpch_q06/vortex-file-compressed 9264120 10663444 0.868774 ns
tpch_q07/vortex-file-compressed 67796670 72542205 0.934582 ns
tpch_q08/vortex-file-compressed 57957177 61092849 0.948674 ns
tpch_q09/vortex-file-compressed 72346710 77178054 0.9374 ns
tpch_q10/vortex-file-compressed 57737833 59950647 0.963089 ns
tpch_q11/vortex-file-compressed 29365960 29685543 0.989234 ns
tpch_q12/vortex-file-compressed 23125011 23202332 0.996668 ns
tpch_q13/vortex-file-compressed 28007640 28494433 0.982916 ns
tpch_q14/vortex-file-compressed 14959229 16258801 0.92007 ns
tpch_q15/vortex-file-compressed 33070843 34139567 0.968695 ns
tpch_q16/vortex-file-compressed 30092927 33160123 0.907503 ns
tpch_q17/vortex-file-compressed 58104370 60377514 0.962351 ns
tpch_q18/vortex-file-compressed 89517139 91881039 0.974272 ns
tpch_q19/vortex-file-compressed 31788121 32109965 0.989977 ns
tpch_q20/vortex-file-compressed 39458051 45699326 0.863427 ns
tpch_q21/vortex-file-compressed 93596331 98220743 0.952918 ns
tpch_q22/vortex-file-compressed 29576956 32915330 0.898577 ns

Copy link
Contributor

Benchmarks: TPC-H on S3

Table of Results
name PR 01f0b84 base 183c831 ratio (PR/base) unit
tpch_q01/parquet 267140519 269330654 0.991868 ns
tpch_q02/parquet 634052278 680259165 0.932075 ns
tpch_q03/parquet 432155277 423950202 1.01935 ns
tpch_q04/parquet 238503064 228685135 1.04293 ns
tpch_q05/parquet 572923633 565931442 1.01236 ns
tpch_q06/parquet 176334650 179029735 0.984946 ns
tpch_q07/parquet 622320342 621912801 1.00066 ns
tpch_q08/parquet 797081946 781233748 1.02029 ns
tpch_q09/parquet 682937666 691137373 0.988136 ns
tpch_q10/parquet 526679950 546560431 0.963626 ns
tpch_q11/parquet 280146855 282026746 0.993334 ns
tpch_q12/parquet 285351481 282650963 1.00955 ns
tpch_q13/parquet 400645128 392438983 1.02091 ns
tpch_q14/parquet 253180540 241031208 1.05041 ns
tpch_q15/parquet 465954895 456226359 1.02132 ns
tpch_q16/parquet 262613729 268417311 0.978379 ns
tpch_q17/parquet 404892339 393038386 1.03016 ns
tpch_q18/parquet 534831500 552801745 0.967492 ns
tpch_q19/parquet 286181518 276600896 1.03464 ns
tpch_q20/parquet 520226371 504773321 1.03061 ns
tpch_q21/parquet 619876659 620873442 0.998395 ns
tpch_q22/parquet 268202247 267036404 1.00437 ns
tpch_q01/vortex-file-compressed 155495800 153973210 1.00989 ns
tpch_q02/vortex-file-compressed 423260622 430162265 0.983956 ns
tpch_q03/vortex-file-compressed 260310482 292673432 0.889423 ns
tpch_q04/vortex-file-compressed 196353935 202790779 0.968259 ns
tpch_q05/vortex-file-compressed 332484391 334203711 0.994855 ns
tpch_q06/vortex-file-compressed 116191718 119528176 0.972086 ns
tpch_q07/vortex-file-compressed 380726669 394674939 0.964659 ns
tpch_q08/vortex-file-compressed 477721868 478162204 0.999079 ns
tpch_q09/vortex-file-compressed 392241155 396745151 0.988648 ns
tpch_q10/vortex-file-compressed 390715962 379784644 1.02878 ns
tpch_q11/vortex-file-compressed 163038337 160560627 1.01543 ns
tpch_q12/vortex-file-compressed 210717175 215348146 0.978495 ns
tpch_q13/vortex-file-compressed 203538557 210070325 0.968907 ns
tpch_q14/vortex-file-compressed 135755460 136337771 0.995729 ns
tpch_q15/vortex-file-compressed 311473864 314257759 0.991141 ns
tpch_q16/vortex-file-compressed 185186720 184627815 1.00303 ns
tpch_q17/vortex-file-compressed 204757650 215808416 0.948794 ns
tpch_q18/vortex-file-compressed 279349522 281345175 0.992907 ns
tpch_q19/vortex-file-compressed 195738692 193372437 1.01224 ns
tpch_q20/vortex-file-compressed 332398340 319425309 1.04061 ns
tpch_q21/vortex-file-compressed 493480397 497815311 0.991292 ns
tpch_q22/vortex-file-compressed 145880633 155544070 0.937873 ns

Copy link
Contributor

Benchmarks: Clickbench on NVME

Table of Results
name PR 01f0b84 base 183c831 ratio (PR/base) unit
clickbench_q00/parquet 2435505 2415534 1.00827 ns
clickbench_q01/parquet 30122116 33909557 0.888308 ns
clickbench_q02/parquet 62463110 65753914 0.949953 ns
clickbench_q03/parquet 51175173 53452091 0.957403 ns
clickbench_q04/parquet 323165238 321130977 1.00633 ns
clickbench_q05/parquet 302745745 323733416 0.93517 ns
clickbench_q06/parquet 2363156 2442326 0.967584 ns
clickbench_q07/parquet 31454574 33702622 0.933298 ns
clickbench_q08/parquet 373846889 390594306 0.957123 ns
clickbench_q09/parquet 545180461 579725752 0.940411 ns
clickbench_q10/parquet 116328024 124218084 0.936482 ns
clickbench_q11/parquet 137418091 146867659 0.935659 ns
clickbench_q12/parquet 306854786 323341453 0.949012 ns
clickbench_q13/parquet 477166376 492538339 0.96879 ns
clickbench_q14/parquet 307268267 323050482 0.951146 ns
clickbench_q15/parquet 339127307 349759376 0.969602 ns
clickbench_q16/parquet 737008369 798439477 0.923061 ns
clickbench_q17/parquet 642802226 688231292 0.933992 ns
clickbench_q18/parquet 1489136226 1532344435 0.971803 ns
clickbench_q19/parquet 40370941 43939360 0.918788 ns
clickbench_q20/parquet 580805550 574899645 1.01027 ns
clickbench_q21/parquet 614198661 612539663 1.00271 ns
clickbench_q22/parquet 925345688 978166501 0.946 ns
clickbench_q23/parquet 3714590423 3929232388 0.945373 ns
clickbench_q24/parquet 187547042 205282875 0.913603 ns
clickbench_q25/parquet 160449412 176782378 0.90761 ns
clickbench_q26/parquet 214919651 234424635 0.916796 ns
clickbench_q27/parquet 726107391 764577608 0.949684 ns
clickbench_q28/parquet 4272827419 4545967418 0.939916 ns
clickbench_q29/parquet 242443840 263569597 0.919848 ns
clickbench_q30/parquet 310224308 337402143 0.91945 ns
clickbench_q31/parquet 370587018 376267041 0.984904 ns
clickbench_q32/parquet 1850088651 1849947603 1.00008 ns
clickbench_q33/parquet 1481293321 1542169109 0.960526 ns
clickbench_q34/parquet 1467402042 1517132418 0.967221 ns
clickbench_q35/parquet 487743392 522290959 0.933854 ns
clickbench_q36/parquet 145388143 155584392 0.934465 ns
clickbench_q37/parquet 66225223 70919543 0.933808 ns
clickbench_q38/parquet 94878439 97932955 0.96881 ns
clickbench_q39/parquet 271869102 284297900 0.956282 ns
clickbench_q40/parquet 43978032 48249034 0.91148 ns
clickbench_q41/parquet 40141111 41250661 0.973102 ns
clickbench_q42/parquet 50516567 54195598 0.932116 ns
clickbench_q00/vortex-file-compressed 3927511 4363517 0.900079 ns
clickbench_q01/vortex-file-compressed 19393723 19762564 0.981336 ns
clickbench_q02/vortex-file-compressed 31163561 32604625 0.955802 ns
clickbench_q03/vortex-file-compressed 39562706 46632949 0.848385 ns
clickbench_q04/vortex-file-compressed 324313994 342432841 0.947088 ns
clickbench_q05/vortex-file-compressed 315132988 324066944 0.972432 ns
clickbench_q06/vortex-file-compressed 4647074 4348986 1.06854 ns
clickbench_q07/vortex-file-compressed 19535465 22236855 0.878517 ns
clickbench_q08/vortex-file-compressed 385311763 422570542 0.911828 ns
clickbench_q09/vortex-file-compressed 462311702 522173739 0.88536 ns
clickbench_q10/vortex-file-compressed 65410953 65560021 0.997726 ns
clickbench_q11/vortex-file-compressed 70293146 76673237 0.916789 ns
clickbench_q12/vortex-file-compressed 250013672 255320242 0.979216 ns
clickbench_q13/vortex-file-compressed 357405568 382822853 0.933606 ns
clickbench_q14/vortex-file-compressed 244474806 246252571 0.992781 ns
clickbench_q15/vortex-file-compressed 393895832 400506368 0.983495 ns
clickbench_q16/vortex-file-compressed 750581416 785619382 0.955401 ns
clickbench_q17/vortex-file-compressed 748477797 765314115 0.978001 ns
clickbench_q18/vortex-file-compressed 1263899131 1371151818 0.921779 ns
clickbench_q19/vortex-file-compressed 25684015 32090957 0.800351 ns
clickbench_q20/vortex-file-compressed 444311681 476448703 0.932549 ns
clickbench_q21/vortex-file-compressed 442257611 495966266 0.891709 ns
clickbench_q22/vortex-file-compressed 648938013 678004214 0.95713 ns
clickbench_q23/vortex-file-compressed 1262624716 1317947002 0.958024 ns
clickbench_q24/vortex-file-compressed 84772433 87878734 0.964652 ns
clickbench_q25/vortex-file-compressed 92850829 94638481 0.981111 ns
clickbench_q26/vortex-file-compressed 113548445 118834897 0.955514 ns
clickbench_q27/vortex-file-compressed 655430163 709420164 0.923896 ns
clickbench_q28/vortex-file-compressed 4945871053 4994719692 0.99022 ns
clickbench_q29/vortex-file-compressed 275885252 248081848 1.11207 ns
clickbench_q30/vortex-file-compressed 220647957 222482001 0.991756 ns
clickbench_q31/vortex-file-compressed 234588377 241009995 0.973355 ns
clickbench_q32/vortex-file-compressed 1297780806 1326068297 0.978668 ns
clickbench_q33/vortex-file-compressed 1344501209 1403360008 0.958059 ns
clickbench_q34/vortex-file-compressed 1377312488 1404355428 0.980744 ns
clickbench_q35/vortex-file-compressed 588262320 609957873 0.964431 ns
clickbench_q36/vortex-file-compressed 59114557 66426606 0.889923 ns
clickbench_q37/vortex-file-compressed 36458006 40782641 0.893959 ns
clickbench_q38/vortex-file-compressed 29994777 30990350 0.967875 ns
clickbench_q39/vortex-file-compressed 112021881 113226557 0.98936 ns
clickbench_q40/vortex-file-compressed 23167722 25784472 0.898515 ns
clickbench_q41/vortex-file-compressed 21633546 24088898 0.898071 ns
clickbench_q42/vortex-file-compressed 31479511 34128415 0.922384 ns

@gatesn gatesn merged commit 5703ad6 into develop Mar 12, 2025
28 of 30 checks passed
@gatesn gatesn deleted the ngates/bump-fsst branch March 12, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants