Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BinaryView::make_view method #2664

Merged
merged 9 commits into from
Mar 12, 2025
Merged

Add BinaryView::make_view method #2664

merged 9 commits into from
Mar 12, 2025

Conversation

robert3005
Copy link
Member

No description provided.

@robert3005 robert3005 added the benchmark Run benchmarks on this branch label Mar 11, 2025
@github-actions github-actions bot removed the benchmark Run benchmarks on this branch label Mar 11, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 11, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #2664 will not alter performance

Comparing rk/make_view (f7a5e93) with develop (6b135ac)

Summary

✅ 775 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

Benchmarks: random_access

Table of Results
name PR 780c4e8 base 58c8fa6 ratio (PR/base) unit
random-access/vortex-tokio-local-disk 2531624 4.47585e+06 0.565618 ns
random-access/parquet-tokio-local-disk 228464543 2.42769e+08 0.941079 ns

@github-actions GitHub Actions
Copy link
Contributor

Benchmarks: TPC-H on NVME

Table of Results
name PR 780c4e8 base 58c8fa6 ratio (PR/base) unit
tpch_q01/arrow 42022957 4.644e+07 0.904886 ns
tpch_q02/arrow 49706210 5.08006e+07 0.978458 ns
tpch_q03/arrow 30883722 3.30687e+07 0.933925 ns
tpch_q04/arrow 22123882 2.31943e+07 0.953849 ns
tpch_q05/arrow 49552415 5.06034e+07 0.979232 ns
tpch_q06/arrow 9437038 9.98129e+06 0.945473 ns
tpch_q07/arrow 74496716 7.80044e+07 0.955032 ns
tpch_q08/arrow 56047998 5.83877e+07 0.959928 ns
tpch_q09/arrow 71670202 7.576e+07 0.946016 ns
tpch_q10/arrow 46452833 4.84902e+07 0.957984 ns
tpch_q11/arrow 25127183 2.5542e+07 0.983759 ns
tpch_q12/arrow 30071019 3.14503e+07 0.956144 ns
tpch_q13/arrow 16343317 1.67111e+07 0.977991 ns
tpch_q14/arrow 14761632 1.70024e+07 0.868209 ns
tpch_q15/arrow 30304387 3.0828e+07 0.983014 ns
tpch_q16/arrow 22369602 2.36893e+07 0.944293 ns
tpch_q17/arrow 61098590 6.51784e+07 0.937405 ns
tpch_q18/arrow 99925042 1.04436e+08 0.956804 ns
tpch_q19/arrow 27817524 3.09704e+07 0.898198 ns
tpch_q20/arrow 37414662 3.84402e+07 0.973322 ns
tpch_q21/arrow 113368881 1.20765e+08 0.938754 ns
tpch_q22/arrow 15743070 1.65332e+07 0.952207 ns
tpch_q01/parquet 112500077 1.1819e+08 0.951861 ns
tpch_q02/parquet 116759484 1.17119e+08 0.996927 ns
tpch_q03/parquet 108999519 1.09424e+08 0.996119 ns
tpch_q04/parquet 60340612 6.23411e+07 0.967911 ns
tpch_q05/parquet 118294330 1.27409e+08 0.928461 ns
tpch_q06/parquet 25540290 2.73475e+07 0.933918 ns
tpch_q07/parquet 135086998 1.43103e+08 0.943981 ns
tpch_q08/parquet 165744617 1.66031e+08 0.998274 ns
tpch_q09/parquet 207797104 2.2126e+08 0.939154 ns
tpch_q10/parquet 134155955 1.38502e+08 0.968618 ns
tpch_q11/parquet 54347623 5.49112e+07 0.989736 ns
tpch_q12/parquet 94381167 9.56353e+07 0.986886 ns
tpch_q13/parquet 150604649 1.55869e+08 0.966224 ns
tpch_q14/parquet 47165648 4.64948e+07 1.01443 ns
tpch_q15/parquet 63132306 6.82295e+07 0.925293 ns
tpch_q16/parquet 52949855 5.50605e+07 0.961667 ns
tpch_q17/parquet 160334343 1.37386e+08 1.16703 ns
tpch_q18/parquet 194376503 2.0651e+08 0.941243 ns
tpch_q19/parquet 73993587 7.69266e+07 0.961872 ns
tpch_q20/parquet 93691393 1.06727e+08 0.877861 ns
tpch_q21/parquet 186648290 1.92737e+08 0.968408 ns
tpch_q22/parquet 50616824 5.33911e+07 0.948039 ns
tpch_q01/vortex-file-compressed 37784353 3.80192e+07 0.993822 ns
tpch_q02/vortex-file-compressed 64081304 6.62033e+07 0.967947 ns
tpch_q03/vortex-file-compressed 32999755 3.59483e+07 0.917978 ns
tpch_q04/vortex-file-compressed 20804743 2.04625e+07 1.01672 ns
tpch_q05/vortex-file-compressed 51826390 5.24254e+07 0.988573 ns
tpch_q06/vortex-file-compressed 9955252 1.06313e+07 0.936407 ns
tpch_q07/vortex-file-compressed 71855923 7.41989e+07 0.968423 ns
tpch_q08/vortex-file-compressed 56248738 6.44482e+07 0.872774 ns
tpch_q09/vortex-file-compressed 74647264 7.49768e+07 0.995605 ns
tpch_q10/vortex-file-compressed 57040809 5.87513e+07 0.970885 ns
tpch_q11/vortex-file-compressed 28888901 3.03433e+07 0.95207 ns
tpch_q12/vortex-file-compressed 23850947 2.46999e+07 0.965628 ns
tpch_q13/vortex-file-compressed 27898459 2.82287e+07 0.988301 ns
tpch_q14/vortex-file-compressed 15467692 1.65838e+07 0.932697 ns
tpch_q15/vortex-file-compressed 33859188 3.38484e+07 1.00032 ns
tpch_q16/vortex-file-compressed 30568120 3.38003e+07 0.904375 ns
tpch_q17/vortex-file-compressed 58520560 6.0098e+07 0.973752 ns
tpch_q18/vortex-file-compressed 89938222 9.41193e+07 0.955577 ns
tpch_q19/vortex-file-compressed 31626982 3.26344e+07 0.969131 ns
tpch_q20/vortex-file-compressed 40939914 4.49134e+07 0.91153 ns
tpch_q21/vortex-file-compressed 95186560 9.80191e+07 0.971102 ns
tpch_q22/vortex-file-compressed 29332930 3.12069e+07 0.939951 ns

@github-actions GitHub Actions
Copy link
Contributor

Benchmarks: TPC-H on S3

Table of Results
name PR 780c4e8 base 58c8fa6 ratio (PR/base) unit
tpch_q01/parquet 261920186 2.60642e+08 1.0049 ns
tpch_q02/parquet 668010374 6.58747e+08 1.01406 ns
tpch_q03/parquet 415568266 4.03936e+08 1.0288 ns
tpch_q04/parquet 226904000 2.2608e+08 1.00365 ns
tpch_q05/parquet 550512829 5.71031e+08 0.964068 ns
tpch_q06/parquet 186525651 1.70504e+08 1.09397 ns
tpch_q07/parquet 626294612 5.99026e+08 1.04552 ns
tpch_q08/parquet 772393253 7.78288e+08 0.992426 ns
tpch_q09/parquet 689118098 6.78543e+08 1.01559 ns
tpch_q10/parquet 528763569 5.16645e+08 1.02346 ns
tpch_q11/parquet 277508603 2.70349e+08 1.02648 ns
tpch_q12/parquet 282975090 2.70604e+08 1.04572 ns
tpch_q13/parquet 372045622 3.88485e+08 0.957684 ns
tpch_q14/parquet 246201959 2.56919e+08 0.958288 ns
tpch_q15/parquet 457606594 4.73336e+08 0.96677 ns
tpch_q16/parquet 253379558 2.71507e+08 0.933234 ns
tpch_q17/parquet 409916429 3.90798e+08 1.04892 ns
tpch_q18/parquet 541652914 5.61134e+08 0.965282 ns
tpch_q19/parquet 287947213 2.79454e+08 1.03039 ns
tpch_q20/parquet 506131409 4.93654e+08 1.02528 ns
tpch_q21/parquet 620883735 6.07485e+08 1.02206 ns
tpch_q22/parquet 263401569 2.65765e+08 0.991106 ns
tpch_q01/vortex-file-compressed 144400770 1.43847e+08 1.00385 ns
tpch_q02/vortex-file-compressed 423897063 4.1541e+08 1.02043 ns
tpch_q03/vortex-file-compressed 279436324 2.90177e+08 0.962985 ns
tpch_q04/vortex-file-compressed 202239342 1.95014e+08 1.03705 ns
tpch_q05/vortex-file-compressed 341137840 3.3203e+08 1.02743 ns
tpch_q06/vortex-file-compressed 116434263 1.15075e+08 1.01182 ns
tpch_q07/vortex-file-compressed 392698192 3.79956e+08 1.03354 ns
tpch_q08/vortex-file-compressed 463270914 4.49847e+08 1.02984 ns
tpch_q09/vortex-file-compressed 391327900 4.0102e+08 0.97583 ns
tpch_q10/vortex-file-compressed 386868352 3.70392e+08 1.04448 ns
tpch_q11/vortex-file-compressed 167121932 1.58388e+08 1.05514 ns
tpch_q12/vortex-file-compressed 218397180 2.14006e+08 1.02052 ns
tpch_q13/vortex-file-compressed 200968703 2.09854e+08 0.95766 ns
tpch_q14/vortex-file-compressed 136417249 1.36443e+08 0.99981 ns
tpch_q15/vortex-file-compressed 296781381 2.92992e+08 1.01293 ns
tpch_q16/vortex-file-compressed 182861835 1.86984e+08 0.977953 ns
tpch_q17/vortex-file-compressed 211907920 2.11982e+08 0.99965 ns
tpch_q18/vortex-file-compressed 277569221 2.76972e+08 1.00216 ns
tpch_q19/vortex-file-compressed 202972429 1.9291e+08 1.05216 ns
tpch_q20/vortex-file-compressed 329227885 3.22002e+08 1.02244 ns
tpch_q21/vortex-file-compressed 482862170 4.69679e+08 1.02807 ns
tpch_q22/vortex-file-compressed 154708419 1.49696e+08 1.03348 ns

@github-actions GitHub Actions
Copy link
Contributor

Benchmarks: Clickbench on NVME

Table of Results
name PR 780c4e8 base 58c8fa6 ratio (PR/base) unit
clickbench_q00/parquet 2497856 2.4956e+06 1.0009 ns
clickbench_q01/parquet 35033857 3.35736e+07 1.04349 ns
clickbench_q02/parquet 69056360 6.57346e+07 1.05053 ns
clickbench_q03/parquet 55816631 5.55261e+07 1.00523 ns
clickbench_q04/parquet 338719465 3.12864e+08 1.08264 ns
clickbench_q05/parquet 329797670 3.13126e+08 1.05324 ns
clickbench_q06/parquet 2342235 2.41627e+06 0.96936 ns
clickbench_q07/parquet 33989019 3.26267e+07 1.04176 ns
clickbench_q08/parquet 396227404 3.93127e+08 1.00789 ns
clickbench_q09/parquet 583447628 5.53047e+08 1.05497 ns
clickbench_q10/parquet 122867500 1.1734e+08 1.04711 ns
clickbench_q11/parquet 148748999 1.44797e+08 1.0273 ns
clickbench_q12/parquet 328116766 3.15049e+08 1.04148 ns
clickbench_q13/parquet 492140854 4.82738e+08 1.01948 ns
clickbench_q14/parquet 333180196 3.20962e+08 1.03807 ns
clickbench_q15/parquet 362953980 3.51657e+08 1.03212 ns
clickbench_q16/parquet 790805183 7.55406e+08 1.04686 ns
clickbench_q17/parquet 704177353 7.04593e+08 0.99941 ns
clickbench_q18/parquet 1660823605 1.55215e+09 1.07002 ns
clickbench_q19/parquet 46294302 4.6188e+07 1.0023 ns
clickbench_q20/parquet 604567883 5.71121e+08 1.05856 ns
clickbench_q21/parquet 667022426 6.41911e+08 1.03912 ns
clickbench_q22/parquet 1009318309 9.68787e+08 1.04184 ns
clickbench_q23/parquet 4002299954 3.86781e+09 1.03477 ns
clickbench_q24/parquet 206805312 1.98703e+08 1.04078 ns
clickbench_q25/parquet 179145274 1.72856e+08 1.03639 ns
clickbench_q26/parquet 231640337 2.2164e+08 1.04512 ns
clickbench_q27/parquet 793082528 7.53693e+08 1.05226 ns
clickbench_q28/parquet 4711506911 4.44526e+09 1.05989 ns
clickbench_q29/parquet 277329609 2.58366e+08 1.0734 ns
clickbench_q30/parquet 339142970 3.23858e+08 1.0472 ns
clickbench_q31/parquet 377222412 3.80862e+08 0.990443 ns
clickbench_q32/parquet 1987469946 1.81977e+09 1.09216 ns
clickbench_q33/parquet 1560860503 1.53865e+09 1.01443 ns
clickbench_q34/parquet 1580282473 1.51603e+09 1.04238 ns
clickbench_q35/parquet 524807736 4.98737e+08 1.05227 ns
clickbench_q36/parquet 150294706 1.45501e+08 1.03295 ns
clickbench_q37/parquet 71916036 6.90526e+07 1.04147 ns
clickbench_q38/parquet 97892490 9.18711e+07 1.06554 ns
clickbench_q39/parquet 289675738 2.83505e+08 1.02177 ns
clickbench_q40/parquet 49446876 4.56087e+07 1.08415 ns
clickbench_q41/parquet 43262024 4.20533e+07 1.02874 ns
clickbench_q42/parquet 52893635 5.43594e+07 0.973035 ns
clickbench_q00/vortex-file-compressed 4445078 4.83409e+06 0.919528 ns
clickbench_q01/vortex-file-compressed 21243601 1.79576e+07 1.18298 ns
clickbench_q02/vortex-file-compressed 30718488 3.24413e+07 0.946894 ns
clickbench_q03/vortex-file-compressed 44111827 4.17108e+07 1.05756 ns
clickbench_q04/vortex-file-compressed 358932873 2.97981e+08 1.20455 ns
clickbench_q05/vortex-file-compressed 343830604 3.30157e+08 1.04142 ns
clickbench_q06/vortex-file-compressed 4841374 4.76491e+06 1.01605 ns
clickbench_q07/vortex-file-compressed 21879222 2.21814e+07 0.986378 ns
clickbench_q08/vortex-file-compressed 400765661 3.63631e+08 1.10212 ns
clickbench_q09/vortex-file-compressed 524012737 4.92067e+08 1.06492 ns
clickbench_q10/vortex-file-compressed 68764791 6.69506e+07 1.0271 ns
clickbench_q11/vortex-file-compressed 73940459 7.76515e+07 0.952209 ns
clickbench_q12/vortex-file-compressed 261150304 2.53577e+08 1.02986 ns
clickbench_q13/vortex-file-compressed 373442449 3.61997e+08 1.03162 ns
clickbench_q14/vortex-file-compressed 268293705 2.48133e+08 1.08125 ns
clickbench_q15/vortex-file-compressed 425513163 3.6562e+08 1.16381 ns
clickbench_q16/vortex-file-compressed 796964134 7.79302e+08 1.02266 ns
clickbench_q17/vortex-file-compressed 783040246 7.58006e+08 1.03303 ns
clickbench_q18/vortex-file-compressed 1340426610 1.30152e+09 1.02989 ns
clickbench_q19/vortex-file-compressed 30626237 2.76237e+07 1.1087 ns
clickbench_q20/vortex-file-compressed 462635788 4.30575e+08 1.07446 ns
clickbench_q21/vortex-file-compressed 499789946 4.59513e+08 1.08765 ns
clickbench_q22/vortex-file-compressed 671923872 6.38569e+08 1.05223 ns
clickbench_q23/vortex-file-compressed 1381505598 1.26807e+09 1.08946 ns
clickbench_q24/vortex-file-compressed 92556100 8.50185e+07 1.08866 ns
clickbench_q25/vortex-file-compressed 106108687 9.51077e+07 1.11567 ns
clickbench_q26/vortex-file-compressed 125926809 1.11649e+08 1.12788 ns
clickbench_q27/vortex-file-compressed 718300029 6.82961e+08 1.05174 ns
clickbench_q28/vortex-file-compressed 5559719489 5.12427e+09 1.08498 ns
clickbench_q29/vortex-file-compressed 272613185 2.71349e+08 1.00466 ns
clickbench_q30/vortex-file-compressed 235994687 2.24226e+08 1.05249 ns
clickbench_q31/vortex-file-compressed 244195582 2.36107e+08 1.03426 ns
clickbench_q32/vortex-file-compressed 1370079247 1.30515e+09 1.04974 ns
clickbench_q33/vortex-file-compressed 1386032122 1.33937e+09 1.03484 ns
clickbench_q34/vortex-file-compressed 1388833885 1.36303e+09 1.01893 ns
clickbench_q35/vortex-file-compressed 620604406 5.88801e+08 1.05401 ns
clickbench_q36/vortex-file-compressed 64974053 6.48343e+07 1.00216 ns
clickbench_q37/vortex-file-compressed 39033708 3.54599e+07 1.10078 ns
clickbench_q38/vortex-file-compressed 32060829 2.94253e+07 1.08957 ns
clickbench_q39/vortex-file-compressed 117207954 1.13644e+08 1.03136 ns
clickbench_q40/vortex-file-compressed 27041496 2.33708e+07 1.15706 ns
clickbench_q41/vortex-file-compressed 23686964 2.35811e+07 1.00449 ns
clickbench_q42/vortex-file-compressed 30758897 3.23845e+07 0.949802 ns

@robert3005
Copy link
Member Author

@gatesn this is now the same performance as the arrow method

@robert3005 robert3005 enabled auto-merge (squash) March 11, 2025 20:11
@robert3005 robert3005 merged commit d292c65 into develop Mar 12, 2025
27 checks passed
@robert3005 robert3005 deleted the rk/make_view branch March 12, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatesn gatesn gatesn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robert3005 @gatesn