Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move build-rust to runs-on #2654

Merged
merged 17 commits into from
Mar 11, 2025
2 changes: 1 addition & 1 deletion .github/workflows/bench-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- image=ubuntu24-full-x64
- disk=large
- spot=false
- tag=${{ matrix.id }}
- tag=${{ matrix.benchmark.id }}
strategy:
matrix:
benchmark:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- image=ubuntu24-full-x64
- disk=large
- spot=false
- tag=${{ matrix.id }}
- tag=${{ matrix.benchmark.id }}
strategy:
matrix:
benchmark:
Expand Down
49 changes: 39 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,14 @@ jobs:

rust-docs:
name: "Rust (docs)"
runs-on: ubuntu-latest
runs-on:
- runs-on=${{ github.run_id }}
- family=m7i+m7i-flex+m7a
- cpu=8
- image=ubuntu24-full-x64
- disk=large
- spot=false
- tag=rust-docs
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-rust
Expand All @@ -112,7 +119,15 @@ jobs:

build-rust:
name: "Rust build (${{matrix.config.name}})"
runs-on: ubuntu-latest
runs-on:
- runs-on=${{ github.run_id }}
- family=m7i+m7i-flex+m7a
- cpu=8
- image=ubuntu24-full-x64
- disk=large
- spot=false
- tag=${{ matrix.config.name }}

env:
# disable lints for build, they will be caught in Rust lint job.
RUSTFLAGS: '-A warnings'
Expand Down Expand Up @@ -142,39 +157,53 @@ jobs:
rustflags: 'RUSTFLAGS="-A warnings --cfg getrandom_backend=\"wasm_js\""'
args: "--target wasm32-unknown-unknown --exclude vortex --exclude vortex-datafusion --exclude vortex-tui"
steps:
- uses: runs-on/action@v1
- uses: actions/checkout@v4
- uses: ./.github/actions/cleanup
- uses: rui314/setup-mold@v1
- uses: ./.github/actions/setup-rust
with:
targets: ${{matrix.config.target || ''}}
- uses: ./.github/actions/setup-c++
- name: Install wasm32 target
if: ${{ matrix.config.target == 'wasm32-unknown-unknown' }}
run: rustup target add wasm32-unknown-unknown
- name: Install cargo-hack
uses: taiki-e/install-action@cargo-hack
- name: Rust Build (${{matrix.config.name}})
run: ${{matrix.config.env.rustflags}} cargo hack ${{matrix.config.command}} --locked ${{matrix.config.args}} --ignore-private

check-min-deps:
name: "Check build with minimal dependencies"
runs-on: ubuntu-latest
runs-on:
- runs-on=${{ github.run_id }}
- family=m7i+m7i-flex+m7a
- cpu=8
- image=ubuntu24-full-x64
- disk=large
- spot=false
- tag=rust-min-deps
steps:
- uses: runs-on/action@v1
- uses: actions/checkout@v4
- uses: ./.github/actions/cleanup
- uses: rui314/setup-mold@v1
- uses: ./.github/actions/setup-rust
- uses: ./.github/actions/setup-c++
- uses: taiki-e/install-action@cargo-hack
- uses: taiki-e/install-action@cargo-minimal-versions
- run: cargo minimal-versions check --direct --workspace --ignore-private

rust-lint:
name: "Rust (lint)"
runs-on: ubuntu-latest
runs-on:
- runs-on=${{ github.run_id }}
- family=m7i+m7i-flex+m7a
- cpu=8
- image=ubuntu24-full-x64
- disk=large
- spot=false
- tag=rust-lint
steps:
- uses: runs-on/action@v1
- uses: actions/checkout@v4
- uses: ./.github/actions/cleanup
- uses: rui314/setup-mold@v1
- uses: ./.github/actions/setup-rust
- uses: ./.github/actions/setup-c++
- name: Rust Lint - Format
run: cargo fmt --all --check
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/fuzz.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ jobs:
- image=ubuntu24-full-x64
- disk=large
- tag=io-fuzz
- spot=false
steps:
- uses: runs-on/action@v1
- uses: actions/checkout@v4
Expand Down Expand Up @@ -56,6 +57,7 @@ jobs:
- image=ubuntu24-full-x64
- disk=large
- tag=ops-fuzz
- spot=false
steps:
- uses: runs-on/action@v1
- uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/generate-tpch-s3.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
- runs-on=${{ github.run_id }}
- family=m7i.2xlarge
- image=ubuntu24-full-x64
- spot=false
env:
REMOTE_PATH: s3://vortex-bench-dev-eu/tpch-sf1/
TMPDIR: /work
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sql-benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- image=ubuntu24-full-x64
- disk=large
- spot=false
- tag=${{ matrix.id }}
- tag=${{ matrix.include.id }}

steps:
- uses: runs-on/action@v1
Expand Down
Loading