feat: vortex CLI convert parquet to Vortex #2649
Merged
+170
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwwmanning
reviewed
Mar 10, 2025
gatesn
reviewed
Mar 11, 2025
| @@ -19,12 +19,19 @@ use vortex::file::VortexWriteOptions; | |||
| use vortex::stream::{ArrayStream, ArrayStreamArrayExt}; | |||
| use vortex::{Array, ArrayRef}; | |||
|
|
|||
| #[derive(Default)] | |||
| pub struct Flags { | |||
| pub quiet: bool, | |||
There was a problem hiding this comment.
Isn't it usually the other way around?!
There was a problem hiding this comment.
I think usually you want the print. See curl or wget for example
vortex-tui/src/convert.rs
Outdated
| ); | ||
| pub async fn exec_convert(input_path: impl AsRef<Path>, flags: Flags) -> VortexResult<()> { | ||
| if !flags.quiet { | ||
| println!( |
| for batch in reader.by_ref() { | ||
| let batch = ArrowStructArray::from(batch?); | ||
| let next_chunk = ArrayRef::from_arrow(&batch, true); | ||
| chunks.push(next_chunk); |
There was a problem hiding this comment.
You should be able to just stream these straight into the writer without buffering everything in memory. using the row group count as your progress indicator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From our discussion earlier today