fix: ConstantArray#take handles nullable indices #2631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatesn
reviewed
Mar 9, 2025
gatesn
reviewed
Mar 9, 2025
robert3005
force-pushed
the
rk/constanttake
branch
from
9cdd9c7 to
f6e9df6
Compare
robert3005
commented
Mar 10, 2025
| self.validity.append_values(false, array.len()); | ||
| } | ||
| Validity::Array(validity) => { | ||
| validity.append_to_builder(&mut self.validity)?; |
There was a problem hiding this comment.
also this builder here was wrong, not sure how a bug like this could happen...
robert3005
force-pushed
the
rk/constanttake
branch
from
376368a to
cbdd4c7
Compare
gatesn
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.