Duckdb conversion traits and simple arrow impl #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2620 will not alter performanceComparing Summary
|
joseph-isaacs
changed the title
0ax1
reviewed
Mar 10, 2025
joseph-isaacs
force-pushed
the
ji/to_duckdb
branch
from
0c1d64f to
d809073
Compare
Deploying vortex-bench with
|
| Latest commit: |
d809073
|
| Status: | 🚫 Build failed. |
# Conflicts: # Cargo.lock
0ax1
reviewed
Mar 10, 2025
0ax1
reviewed
Mar 10, 2025
| } | ||
| } | ||
|
|
||
| fn from_duckdb_list(list: LogicalTypeHandle) -> DType { |
There was a problem hiding this comment.
Same here, could consider making this more rustic:
impl From<LogicalTypeHandle>..
There was a problem hiding this comment.
I am not sure we can, since we I need a nullability above and I would need a dummy struct to control the from impl here
0ax1
approved these changes
Mar 10, 2025
0ax1
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple converter via arrow