Segment prefetcher #2613
Open
Segment prefetcher #2613
+1,084
−200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarks: TPC-H on NVMETable of Results
|
Benchmarks: Clickbench on NVMETable of Results
|
Benchmarks: TPC-H on S3Table of Results
|
onursatici
force-pushed
the
os/scan
branch
2 times, most recently
from
a30f27c to
6bf0490
Compare
gatesn
reviewed
Mar 12, 2025
| @@ -275,6 +275,22 @@ impl Layout { | |||
| .register_splits(self, field_mask, row_offset, splits) | |||
| } | |||
|
|
|||
| pub fn required_segments( | |||
There was a problem hiding this comment.
Please add docs to public functions
robert3005
reviewed
Mar 12, 2025
| location: location.clone(), | ||
| callback: request.callback, | ||
| }) | ||
| let inflight_segments: InflightSegments = Default::default(); |
There was a problem hiding this comment.
You could just do
Suggested change
| let inflight_segments: InflightSegments = Default::default(); | |
| let inflight_segments = InflightSegments::default(); |
Comment on lines
+290
to
+292
| if items.is_empty() { | ||
| items.reserve(*this.requests_ready_chunks); | ||
| } |
There was a problem hiding this comment.
can pull this out of the loop to initialization of items
Comment on lines
+309
to
+311
| if items.is_empty() { | ||
| items.reserve(*this.requests_ready_chunks); | ||
| } |
| fn range(&self) -> Range<u64> { | ||
| self.location.offset..self.location.offset + self.location.length as u64 | ||
| } | ||
| } | ||
|
|
||
| impl From<(SegmentId, Segment, oneshot::Receiver<()>)> for SegmentRequest { |
There was a problem hiding this comment.
This from is way too cute, we should add a method directly on SegmentRequest
| let nchunks = layout.nchildren() - (if layout.metadata().is_some() { 1 } else { 0 }); | ||
| let mut offset = row_offset; | ||
| for i in 0..nchunks { | ||
| let child = layout.child(i, layout.dtype().clone(), format!("[{}]", i))?; |
There was a problem hiding this comment.
Suggested change
| let child = layout.child(i, layout.dtype().clone(), format!("[{}]", i))?; | |
| let child = layout.child(i, layout.dtype().clone(), format!("[{i}]"))?; |
| }; | ||
|
|
||
| let cancelled_segments: Vec<_> = { | ||
| let mut store = self.store.write().vortex_expect("poisoned lock"); |
There was a problem hiding this comment.
Suggested change
| let mut store = self.store.write().vortex_expect("poisoned lock"); | |
| let mut store = self.store.write()?; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.