Feature/module pattern refactor #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…import of ngProgress and refactor tests
…urse of action is actually to implement it myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Blocker
The VictorBjelkholm/ngProgress is completely broken now, and has a number of major performance problems. I attempted to fork it to make it at least commonjs compatible, but the way the modules are registered attempting to bind to controller scope or something is not compatible with a well formatted library.
Still todo, roll my own progress dom interaction - shouldn't be too hard as this was a 1:1 wrapper, so the methods would just need to be extended to do the actual implementation.
Release type: #major#