Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump minimal rust version to 1.81 #253

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Dec 16, 2024

No description provided.

Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
@Mossaka Mossaka marked this pull request as ready for review December 16, 2024 19:09
Copy link
Collaborator

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the Spin Dockerfile rust version also be bumped:

FROM --platform=${BUILDPLATFORM} rust:1.79 AS build

CHANGELOG.md Outdated Show resolved Hide resolved
tests/src/integration_test.rs Show resolved Hide resolved
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Copy link
Collaborator

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mossaka I think it would be good to get this in. E2E tests failing we can take on in another pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants