-
Notifications
You must be signed in to change notification settings - Fork 270
Spin Factors #2753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Spin Factors #2753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lann Martin <[email protected]>
factors: Improve tests
Avoids some boilerplate in factor test setup. Use this to establish a `test_env` pattern for factor tests. Signed-off-by: Lann Martin <[email protected]>
factors: Add TestEnvironment::default_manifest_extend
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
And add a simple test. Signed-off-by: Lann Martin <[email protected]>
Add a llm-factors
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Kate Goldenring <[email protected]>
factors: Add Error type
Signed-off-by: Kate Goldenring <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Add some more documentation to factors
Llm factor host impl test
Remove Factor::runtime_config_json_schema
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
factor: Add key value Redis factor
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
factors: Enhance Factor doc comments
Signed-off-by: Caleb Schoepp <[email protected]>
factors: Break up the Error::RuntimeFactorError monopoly
Signed-off-by: Caleb Schoepp <[email protected]>
Initial key values
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
factors: Fix toml key tracking
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
[factors] More CI fixes
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
[Factors] Fix logging
Unfortunately there are some toolchains that don't emit enough information for this heuristic to detect that they are positively safe, so we'll need to default to allow. Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Relax buggy wasi-sdk heuristic
Fix subtle runtime config issues
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
rylev
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
fibonacci1729
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIP: #2518