Skip to content

Spin Factors #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 281 commits into from
Aug 27, 2024
Merged

Spin Factors #2753

merged 281 commits into from
Aug 27, 2024

Conversation

lann
Copy link
Collaborator

@lann lann commented Aug 23, 2024

SIP: #2518

lann and others added 30 commits July 10, 2024 17:25
Avoids some boilerplate in factor test setup.

Use this to establish a `test_env` pattern for factor tests.

Signed-off-by: Lann Martin <[email protected]>
factors: Add TestEnvironment::default_manifest_extend
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
And add a simple test.

Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
Signed-off-by: Kate Goldenring <[email protected]>
Add some more documentation to factors
Remove Factor::runtime_config_json_schema
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
factors: Enhance Factor doc comments
Signed-off-by: Caleb Schoepp <[email protected]>
factors: Break up the Error::RuntimeFactorError monopoly
calebschoepp and others added 19 commits August 26, 2024 14:10
Signed-off-by: Lann Martin <[email protected]>
Unfortunately there are some toolchains that don't emit enough
information for this heuristic to detect that they are positively safe,
so we'll need to default to allow.

Signed-off-by: Lann Martin <[email protected]>
@lann lann changed the title Factors CI testing Spin Factors Aug 27, 2024
Copy link
Collaborator

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lann lann merged commit 720c7f4 into main Aug 27, 2024
17 checks passed
@lann lann deleted the factors branch March 24, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants