Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore asset globs from being watched when using direct-mounts #2203

Merged
merged 1 commit into from
Jan 3, 2024
Merged

ignore asset globs from being watched when using direct-mounts #2203

merged 1 commit into from
Jan 3, 2024

Conversation

karthik2804
Copy link
Contributor

@karthik2804 karthik2804 commented Dec 23, 2023 •
edited
Loading

fixes #2202

calebschoepp
calebschoepp approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@calebschoepp calebschoepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make sure Ivan looks at this too.

src/commands/watch.rs Outdated Show resolved Hide resolved
itowlson
itowlson reviewed Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM although I see it is marked as draft?

src/commands/watch.rs Outdated Show resolved Hide resolved
@karthik2804 karthik2804 force-pushed the spin_watch_static_files branch from 5b1c1d2 to 7327664 Compare January 2, 2024 21:10
@karthik2804 karthik2804 marked this pull request as ready for review January 2, 2024 21:10
@karthik2804
Copy link
Contributor Author

@itowlson updated the comment and marked it as ready for review.

@itowlson itowlson merged commit 02a00b9 into spinframework:main Jan 3, 2024
11 checks passed
@karthik2804 karthik2804 deleted the spin_watch_static_files branch January 3, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itowlson itowlson itowlson approved these changes

@calebschoepp calebschoepp calebschoepp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spin watch - Do not restart on changes to mounted files when using --direct-mounts
3 participants
@karthik2804 @itowlson @calebschoepp