Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with Importer's source selector dialog #245

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

soininen
Copy link
Contributor

@soininen soininen commented Jan 10, 2025

  • If souce type stored in the mapping clashes with source type, user now gets a warning before seeing the source selector.
  • In the above case and if user chooses a different source type to what is defined in the mapping, the undo stack is marked as dirty so it is actually possible to save the specification afterwards.
  • The source selector dialog is now shown only after the specification window is shown. This enables showing correct icon in the dialog as well.

No associated issue

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes in Toolbox repo have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

- If souce type stored in the mapping clashes with source type,
  user now gets a warning before seeing the source selector.
- In the above case and if user chooses a different source type
  to what is defined in the mapping, the undo stack is marked
  as dirty so it is actually possible to save the specification
  afterwards.
- The source selector dialog is now shown only after the specification
  window is shown. This enables showing correct icon in the dialog
  as well.
@soininen soininen force-pushed the fix_importer_source_selector_dialog branch from 7dce907 to df47e20 Compare January 10, 2025 09:08
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 63.01%. Comparing base (49f859a) to head (df47e20).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ine_items/importer/widgets/import_editor_window.py 58.82% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   63.02%   63.01%   -0.01%     
==========================================
  Files         168      168              
  Lines       17970    17979       +9     
  Branches     2069     2070       +1     
==========================================
+ Hits        11325    11329       +4     
- Misses       6042     6046       +4     
- Partials      603      604       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit 47074fe into master Jan 10, 2025
11 of 12 checks passed
@soininen soininen deleted the fix_importer_source_selector_dialog branch January 10, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant