Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

811 get rid of model tb and model sstructure #812

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

manuelma
Copy link
Collaborator

@manuelma manuelma commented Nov 29, 2023

Fixes #811

Checklist before merging

  • Documentation is up-to-date
  • Unit tests have been added/updated accordingly
  • Code has been formatted according to SpineOpt's style
  • Unit tests pass

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34f2b9d) 86.26% compared to head (9c6f089) 86.18%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #812      +/-   ##
==========================================
- Coverage   86.26%   86.18%   -0.08%     
==========================================
  Files         133      134       +1     
  Lines        2955     3099     +144     
==========================================
+ Hits         2549     2671     +122     
- Misses        406      428      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manuelma manuelma merged commit 3a128d4 into master Nov 29, 2023
@manuelma manuelma deleted the 811_get_rid_of_model__tb_and_model_sstructure branch November 29, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of model__temporal_block and model__stochastic_structure
2 participants