Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use align_variable_duration_unit function instead of convert_to_days #1154

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

datejada
Copy link
Member

@datejada datejada commented Jan 17, 2025

Reusing the function align_variable_duration_unit instead of creating a new one convert_to_days

Fixes #1152

Checklist before merging

  • Documentation is up-to-date
  • Unit tests have been added/updated accordingly
  • Code has been formatted according to SpineOpt's style
  • Unit tests pass

@datejada datejada requested a review from nnhjy January 17, 2025 15:08
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.39%. Comparing base (f6bf05a) to head (d68fe91).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1154      +/-   ##
==========================================
+ Coverage   87.35%   87.39%   +0.03%     
==========================================
  Files         143      143              
  Lines        4135     4132       -3     
==========================================
- Hits         3612     3611       -1     
+ Misses        523      521       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datejada datejada marked this pull request as ready for review January 17, 2025 17:16
@datejada
Copy link
Member Author

datejada commented Jan 17, 2025

@nnhjy your function does the same as the one I added before. So, I am reusing yours since it is better documented and to avoid having dirty hacks inside the functions.
Please let me know if you have any comments, otherwise, I will merge this change.
Thanks!

@datejada datejada merged commit 18e4ef5 into master Jan 21, 2025
7 checks passed
@datejada datejada deleted the 1152-improve-conversion-to-days branch January 21, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve convert_to_days function
1 participant