golangci-lint: add copyloopvar & update code #5741
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4rlo
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
c4rlo
changed the title
c4rlo
force-pushed
the
lint-copyloopvar
branch
from
f69b524 to
ebc2d49
Compare
amartinezfayo
previously approved these changes
Jan 8, 2025
|
@c4rlo Could you fix the conflicting changes so we can merge this? Thank you! |
Add the copyloopvar linter, which enforces not creating explicit copies of the for loop iterator variable, which is no longer necessary as of Go 1.22. Signed-off-by: Carlo Teubner <[email protected]>
c4rlo
force-pushed
the
lint-copyloopvar
branch
from
ebc2d49 to
53b30d2
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
copyloopvarlinter, which enforces not creating explicit copies of the for loop iterator variable, which is no longer necessary as of Go 1.22.