Fixes how upstream-authority-ejbca integration test calls kubectl and helm #5613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00-setup-kind downloads kubectl, helm and kind to ./bin folder upstream-authority-ejbca test now calls the binaries from this prepared bin folder Signed-off-by: Nico Weisenauer <[email protected]>
nweisenauer-sap
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
Signed-off-by: Nico Weisenauer <[email protected]>
amartinezfayo
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
upstream-authority-ejbca test now calls the binaries from the ./bin folder
Description of change
On our runners, the new integration test
upstream-authority-ejbcafails, complaining thathelmandkubectlare not preinstalled. However, this test, similar to theupstream-authority-cert-manager, downloads these tools beforehand (inside the00-setup-kind script). The issue is that the script downloads these tools to the./binfolder, which is fine, but the test itself does mixed calls ofkubectl, sometimes usingkubectl, sometimes./bin/kubectl. Also, the prerequisite checks do not check for the./binfolder.Which issue this PR fixes