Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post launch Log level control for the Server #4880

Merged
merged 20 commits into from
Mar 11, 2024
Merged

Post launch Log level control for the Server #4880

merged 20 commits into from
Mar 11, 2024

Commits on Mar 11, 2024

  1. Initial support for dynamically adjustable log levels. 

    Add list command to cli.

Add some of the receiving services in the server "run" instance.

Add the "registry" of loggers (currently a btree)

Beginning unit testing on naming ordering.

Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    b1c09c0 View commit details
    Browse the repository at this point in the history

  2. Fixed logical error in comment. 

    Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    660ef92 View commit details
    Browse the repository at this point in the history

  3. Functional for get and set logger commands. 

    Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    0d9355a View commit details
    Browse the repository at this point in the history

  4. Adjustments to improve JSON output formatting. 

    JSON now outputs log levels as their logrus lower-case strings.

Some unit testing on logger.get cli commands.

Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    adef016 View commit details
    Browse the repository at this point in the history

  5. Realign to final spire-api-sdk api. 

    Complete unit testing for spire-server cli.

Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    57f3da0 View commit details
    Browse the repository at this point in the history

  6. Rework server commands to use new API 

    Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    e274962 View commit details
    Browse the repository at this point in the history

  7. Fix off-by one log level setting, introduced with new API change. 

    Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    25ef540 View commit details
    Browse the repository at this point in the history

  8. Fix the issue of not configuring the log.Logger (from pkg) or 

    logrus.Logger.

Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    801e8af View commit details
    Browse the repository at this point in the history

  9. Make the service fields private, small renames, add a type. 

    The Logger service fields are now private, the service config fields
remain public.

The Logger variable / field names are now log (or Log) to match
conventions.

The logger package now adds a Logger type which extends the logrus.Logger
interface with set log level and get log level funcs.

Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    6d912a8 View commit details
    Browse the repository at this point in the history

  10. Add the RootLog field to the config in the endpoints_test.go. 

    This fixes the inability of this unit test to intialize the new GRPC
logger service, as it requires a Logger type that also includes the
ability to change log levels.

Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    0355b90 View commit details
    Browse the repository at this point in the history

  11. Minor adjustements to conform with go's linting policies. 

    Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    5aa92ff View commit details
    Browse the repository at this point in the history

  12. Fixes for small code review points. Additions for testing under 

    endpoints_test.go

Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    10ac0f9 View commit details
    Browse the repository at this point in the history

  13. Flipped all testing of various access methods to true until issue 4940 

    is fixed.

Removed allow_admin from policy_data.json until determination can be
made to make this allow_admin

Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    2c35b8b View commit details
    Browse the repository at this point in the history

  14. Add Logger GRPC Service unit testing. 

    Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    daeb76d View commit details
    Browse the repository at this point in the history

  15. Fix lint issues. 

    Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    b5c6058 View commit details
    Browse the repository at this point in the history

  16. Fix unit test that was unnoticed as the test was cached. 

    Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    9966197 View commit details
    Browse the repository at this point in the history

  17. Fix unit tests on windows. 

    Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    d07317e View commit details
    Browse the repository at this point in the history

  18. goimport get_posix_test.go 

    Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    e4d675f View commit details
    Browse the repository at this point in the history

  19. goimport format the windows test data in get_windows_test.go 

    Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    d8ea93d View commit details
    Browse the repository at this point in the history

  20. Fix windows unit testing of logger set cli command. 

    Signed-off-by: Edwin Buck <[email protected]>
    @edwbuck @MarcosDY
    edwbuck authored and MarcosDY committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    1c5c144 View commit details
    Browse the repository at this point in the history