Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dockerfile warnings #461

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Fix Dockerfile warnings #461

merged 2 commits into from
Jan 15, 2025

Conversation

faisal-memon
Copy link
Contributor

Fixes these warning on make docker-build:

 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 4)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 25)

@faisal-memon
Fix Dockerfile warnings
8c1975e 
Signed-off-by: Faisal Memon <[email protected]>
kfox1111
kfox1111 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@kfox1111 kfox1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! :)

@MarcosDY MarcosDY merged commit 82f8ff9 into spiffe:main Jan 15, 2025
6 checks passed
@faisal-memon faisal-memon deleted the dockerfiles branch January 15, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosDY MarcosDY MarcosDY approved these changes

@kfox1111 kfox1111 kfox1111 approved these changes

@azdagron azdagron Awaiting requested review from azdagron azdagron is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faisal-memon @kfox1111 @MarcosDY