Support Ed25519 signature algorithm #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenz
requested review from
amartinezfayo,
evan2645 and
azdagron
as code owners
azdagron
approved these changes
Jan 17, 2024
|
@lorenz can you grant maintainers the ability to push commits on this PR? (there is a checkbox). Otherwise, you and I will need to coordinate the merge (it needs to be up-to-date, which I can't do unless permitted) |
|
I generally always enable this, but apparently GitHub doesn't let you do this if the repo is in an organization (https://github.com/orgs/community/discussions/5634). I can rebase onto whatever you need, just tell me. |
|
Feel free to just merge in the latest main (or use Update Branch button) and I'll make sure this is merged next. |
This adds support for the Ed25519 signature algorithm which is supported by Go, but was not fully plumbed through in go-spiffe. Signed-off-by: Lorenz Brun <[email protected]>
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the Ed25519 signature algorithm which is supported by Go, but was not fully plumbed through in go-spiffe.