no interface name in annotation to support multiple NIC #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icarus9913
added
pr/not-ready
Icarus9913
force-pushed
the
feat/wk/multiple-nic
branch
4 times, most recently
from
06d31bc to
3c96d67
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2618 +/- ##
==========================================
+ Coverage 80.82% 81.00% +0.18%
==========================================
Files 49 49
Lines 5303 5339 +36
==========================================
+ Hits 4286 4325 +39
+ Misses 859 856 -3
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Icarus9913
force-pushed
the
feat/wk/multiple-nic
branch
2 times, most recently
from
38de2e5 to
5e59740
Compare
Icarus9913
force-pushed
the
feat/wk/multiple-nic
branch
7 times, most recently
from
dfd7876 to
bf325f4
Compare
Icarus9913
force-pushed
the
feat/wk/multiple-nic
branch
from
bf325f4 to
b3292ca
Compare
weizhoublue
reviewed
Nov 21, 2023
docs/usage/spider-ippool-zh_CN.md
Outdated
| @@ -70,6 +70,22 @@ ipam.spidernet.io/ippool: |- | |||
| } | |||
| ``` | |||
|
|
|||
| 在使用注解 `ipam.spidernet.io/ippools` 用于多网卡指定时，你可显式的通过指定 `interface` 字段标明网卡名，也可以通过**数组顺序排列**让第几张卡用哪些 IP 池。另外，字段 `cleangateway` 标明是否需要根据 IP 池中的 `gateway` 字段生成一条默认路由，当 `cleangateway` 为 `true` 标明无需生成默认路由。(默认为false) | |||
|
|
|||
| > 多网卡场景下，一般无法为路由表 `main` 表生成两条及以上的默认路由。因此，可借助 `cleangateway: true` 来标明不根据 IP 池 gateway 字段生成默认路由。 | |||
There was a problem hiding this comment.
这句有误导，即使不加 cleangateway ， coordinator也会调谐好，不存在 问题
weizhoublue
changed the title
Icarus9913
force-pushed
the
feat/wk/multiple-nic
branch
from
b3292ca to
47d7f55
Compare
Icarus9913
added
pr/ready-review
Icarus9913
force-pushed
the
feat/wk/multiple-nic
branch
from
47d7f55 to
c5b2e07
Compare
Icarus9913
force-pushed
the
feat/wk/multiple-nic
branch
2 times, most recently
from
8ceca9b to
643ea09
Compare
Icarus9913
added
pr/not-ready
Signed-off-by: Icarus9913 <[email protected]>
Icarus9913
force-pushed
the
feat/wk/multiple-nic
branch
from
643ea09 to
2f20915
Compare
Icarus9913
added
pr/ready-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpiderIPPool.Status.AllocatedIPspropertyinterface, it just display the NIC that's all.Support multiple annotation
ipam.spidernet.io/ippoolsnew usage just like:Signed-off-by: Icarus9913 [email protected]
What type of PR is this?
new feature
What this PR does / why we need it:
support multiple NIC with no name specified
Which issue(s) this PR fixes:
close #2614