intersphinx: Resolve implicit self-references #13322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
force-pushed
the
cleanup/resolve-implicit-self-references
branch
from
c947dcb to
59c3f5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When we added
intersphinx_resolve_selfin #13291, it only applied to the:external:<...>:`...`role. This extends the functionality to implicit intersphinx references of the form:ref:`astropy:blah`.I'm not hugely happy with adding intersphinx-specific code into
ReferencesResolver, but the surface area is very limited and clearly demarked.A
References
intersphinx_resolve_selfoption #13291