Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release commit with deploy key #66

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

milliams
Copy link
Collaborator

@milliams milliams commented Feb 6, 2025

I created an SSH key locally with with:

ssh-keygen -q -t ed25519 -f ~/temp/doxylink_release_key -C '' -N ''

and in the doxylink GitHub settings page created a deploy key called "Release deploy key" with that key's public key and with write permissions. I put the private key part in an Actions secret called DEPLOY_KEY.

I then edited the branch protection ruleset to add Deploy Keys to the exception list.

This PR updates the release workflow to use that deploy key to check out the code so that when it pushes the tag and release commit it is allowed to bypass the PR requirement.

Copy link
Collaborator

@JasperCraeghs JasperCraeghs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! I'll create the releases by myself in the future unless you object.

@milliams milliams merged commit 5a2975c into master Feb 6, 2025
5 checks passed
@milliams milliams deleted the deploy-key-release branch February 6, 2025 22:12
@milliams
Copy link
Collaborator Author

milliams commented Feb 6, 2025

I'll create the releases by myself in the future unless you object.

No problem at all. I'll make this release now to check that it's working, but I'm happy for you to make future releases whenever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants