-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to 2023 year in testdata #64
base: main
Are you sure you want to change the base?
Conversation
CI is failing fort other reasons. Sigh... |
Can this be fixed permanently with |
I agree we need a better approach. However allowing the tests to pass would prevent user from remembering these files need to be changed. But I haven't looked at the code in a while so I might be missing something. |
Such a failure sounds suitable for your CI (upstream), but I think basically anyone else will be unhappy with that breakage. There are situations when even older versions are desirable to use (e.g. bisecting regressions across history) and then similar newly-appearing failures can be annoying. |
Damn it, I was cleaning up some public forked repos. |
This PR is being marked as stale due to a long period of inactivity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship this, get tests passing, and open a new issue to revisit this.
I just ran into this as well and it's annoying to have test flakes while working on other things.
Close #63.