-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made first letter of default toggle flag usage lowercase according to cobra conventions. #110
base: main
Are you sure you want to change the base?
Conversation
… cobra convention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha! Now I see why you opened that other PR 😁. Thanks for this.
Could you look into the CI failure?
@@ -87,7 +87,7 @@ func init() { | |||
{{ end }} | |||
// Cobra also supports local flags, which will only run | |||
// when this action is called directly. | |||
rootCmd.Flags().BoolP("toggle", "t", false, "Help message for toggle") | |||
rootCmd.Flags().BoolP("toggle", "t", false, "help message for toggle") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there’s another one below at line 160. Might as well fix that one too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll look into those when I have some more time.
…according to cobra convention
The other one on line 160 has been fixed. I'll start looking into the checks once you run the workflows again. |
Looks like the latest commit to the main branch of cobra-cli that I forked from failed all of the same checks, so it wasn't something that I did, and I'm not sure how to fix all of them. |
I'll have to look into it. |
The first letter in the default help message for the toggle flag was uppercase, so I made it lowercase according to cobra convention.