Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made first letter of default toggle flag usage lowercase according to cobra conventions. #110

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JungleHornet
Copy link

The first letter in the default help message for the toggle flag was uppercase, so I made it lowercase according to cobra convention.

@CLAassistant
Copy link

CLAassistant commented Jul 12, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! Now I see why you opened that other PR 😁. Thanks for this.
Could you look into the CI failure?

@@ -87,7 +87,7 @@ func init() {
{{ end }}
// Cobra also supports local flags, which will only run
// when this action is called directly.
rootCmd.Flags().BoolP("toggle", "t", false, "Help message for toggle")
rootCmd.Flags().BoolP("toggle", "t", false, "help message for toggle")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there’s another one below at line 160. Might as well fix that one too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll look into those when I have some more time.

@JungleHornet
Copy link
Author

JungleHornet commented Jul 12, 2024

The other one on line 160 has been fixed. I'll start looking into the checks once you run the workflows again.

@JungleHornet
Copy link
Author

Looks like the latest commit to the main branch of cobra-cli that I forked from failed all of the same checks, so it wasn't something that I did, and I'm not sure how to fix all of them.

@marckhouzam
Copy link
Collaborator

Looks like the latest commit to the main branch of cobra-cli that I forked from failed all of the same checks, so it wasn't something that I did, and I'm not sure how to fix all of them.

I'll have to look into it.
Thanks. I'll get back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants