Support lightless mode #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyokatarz
commented
Sep 16, 2024
Comment on lines
+45
to
+54
| // Define modes | ||
| #define MODE_JOYSTICK 1 | ||
| #define MODE_KEYBOARD 2 | ||
| #define MODE_LIGHT_ON 1 | ||
| #define MODE_LIGHT_OFF 0 | ||
|
|
||
| // Eeprom addresses | ||
| #define EEPROM_CONTROL_ADDRESS 0 | ||
| #define EEPROM_LIGHT_ADDRESS 1 | ||
|
|
There was a problem hiding this comment.
Define new variables for later autocomplete. No more "Which one is joystick mode, which one is keyboard mode"
Comment on lines
+96
to
+104
| void updateEEPROM(int address, int newValue) { | ||
| int readState = EEPROM.read(address); | ||
|
|
||
| if (readState == newValue) return; | ||
|
|
||
| EEPROM.update(address, newValue); | ||
| delay(200); | ||
| } | ||
|
|
There was a problem hiding this comment.
Refactor updating EEPROM into a function, no need to delay(200) everywhere anymore. Now automatically delay(200) if an update is done
Comment on lines
+118
to
+139
| int Button3State = digitalRead(BT_C); //Read Btn-C | ||
|
|
||
| bool IsButtonAPressed = Button1State == LOW; | ||
| bool IsButtonBPressed = Button2State == LOW; | ||
| bool IsButtonCPressed = Button3State == LOW; | ||
|
|
||
| bool UseJoystick = IsButtonAPressed && !IsButtonBPressed; | ||
| bool UseKeyboard = IsButtonBPressed && !IsButtonAPressed; | ||
| bool UseLight = !IsButtonCPressed; | ||
|
|
||
| if (UseJoystick) { | ||
| updateEEPROM(EEPROM_CONTROL_ADDRESS, MODE_JOYSTICK); | ||
| } else if (UseKeyboard) { | ||
| updateEEPROM(EEPROM_CONTROL_ADDRESS, MODE_KEYBOARD); | ||
| } else { | ||
| updateEEPROM(EEPROM_CONTROL_ADDRESS, MODE_JOYSTICK); | ||
| } | ||
|
|
||
| if (UseLight) { | ||
| updateEEPROM(EEPROM_LIGHT_ADDRESS, MODE_LIGHT_ON); | ||
| } else { | ||
| updateEEPROM(EEPROM_LIGHT_ADDRESS, MODE_LIGHT_OFF); |
There was a problem hiding this comment.
Refactored this as well :D
If C button is pressed then update EEPROM address to LIGHT_OFF, then later in the lights() function it will check if the light address is on or off and determine
There was a problem hiding this comment.
Note that it's independent of control mode
So if (B + C) is pressed -> Keyboard mode and lightless
Joystick with light on by default
Comment on lines
+147
to
+150
| int CONTROL_MODE = EEPROM.read(EEPROM_CONTROL_ADDRESS); | ||
|
|
||
| if (CONTROL_MODE == MODE_JOYSTICK) joy_mode(); | ||
| else if (CONTROL_MODE == MODE_KEYBOARD) keyboard_mode(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have a controller with me to test :( If you have one in handy, can you debug/modify this so it works? :D