[DRAFT] Protocol redesign #57
Draft
+608
−202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drew-Wagner
reviewed
Apr 7, 2025
Comment on lines
+27
to
+31
| def bandpass_resample(): | ||
| @takes("epoch", "info", "target_sfreq", "fmin", "fmax") | ||
| @provides("epoch", "sfreq", "target_sfreq", "fmin", "fmax") | ||
| def _bandpass_resample(epoch, info, target_sfreq, fmin, fmax): | ||
| """Bandpass filter and resample an epoch.""" |
There was a problem hiding this comment.
This is more what I had in mind as it makes it easy to configure from the hparams file. See how it is a function which creates a dynamic item with the desired parameters?
DONT commit the suggestion directly, as it is just to illustrate
Suggested change
| def bandpass_resample(): | |
| @takes("epoch", "info", "target_sfreq", "fmin", "fmax") | |
| @provides("epoch", "sfreq", "target_sfreq", "fmin", "fmax") | |
| def _bandpass_resample(epoch, info, target_sfreq, fmin, fmax): | |
| """Bandpass filter and resample an epoch.""" | |
| def bandpass_resample(target_sfreq, fmin, fmax): | |
| @takes("epoch", "info") | |
| @provides("epoch") | |
| def _bandpass_resample(epoch, info): | |
| """Bandpass filter and resample an epoch.""" |
There was a problem hiding this comment.
This will allow us to do something like this in the yaml file:
dynamic_items:
- !apply:bandpass_resample
fmin: 0.5
fmax: 22
target_sfreq: 128
Comment on lines
+58
to
+59
| #dynamic_items: | ||
| # - !name:dataio.preprocessing.to_tensor |
There was a problem hiding this comment.
This should include all preprocessing steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the integration of the new dataio files and paradigms. It looks to replace the bash files that run the experiment and the hyper-parameter optimization with new python files. The main changes pertain to the train.py file that loads the data using dataio files, new run_experiments.py file, and later a new run_hparam_optimization.py file that integrates with WANDB.