Skip to content

Commit

Permalink
PLT-802: Deprecate ssh_key attribute. (#374)
Browse files Browse the repository at this point in the history
  • Loading branch information
nikchern authored Nov 10, 2023
1 parent f0a2f0d commit f27e849
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 10 deletions.
14 changes: 7 additions & 7 deletions docs/resources/cluster_aws.md
Original file line number Diff line number Diff line change
Expand Up @@ -163,13 +163,13 @@ resource "spectrocloud_cluster_aws" "cluster" {

Required:

- `region` (String)
- `ssh_key_name` (String)
- `region` (String) The AWS region to deploy the cluster in.
- `ssh_key_name` (String) The name of the SSH key to launch the cluster.

Optional:

- `control_plane_lb` (String) Control plane load balancer type. Valid values are `Internet-facing` and `internal`. Defaults to `` (empty string).
- `vpc_id` (String)
- `vpc_id` (String) The VPC ID to deploy the cluster in. If not provided, VPC will be provisioned dynamically.


<a id="nestedblock--machine_pool"></a>
Expand All @@ -178,8 +178,8 @@ Optional:
Required:

- `count` (Number) Number of nodes in the machine pool.
- `instance_type` (String)
- `name` (String)
- `instance_type` (String) The instance type to use for the machine pool nodes.
- `name` (String) The name of the machine pool.

Optional:

Expand All @@ -190,9 +190,9 @@ Optional:
- `capacity_type` (String) Capacity type is an instance type, can be 'on-demand' or 'spot'. Defaults to 'on-demand'.
- `control_plane` (Boolean) Whether this machine pool is a control plane. Defaults to `false`.
- `control_plane_as_worker` (Boolean) Whether this machine pool is a control plane and a worker. Defaults to `false`.
- `disk_size_gb` (Number)
- `disk_size_gb` (Number) The disk size in GB for the machine pool nodes.
- `max` (Number) Maximum number of nodes in the machine pool. This is used for autoscaling the machine pool.
- `max_price` (String)
- `max_price` (String) Maximum price to bid for spot instances. Only applied when instance type is 'spot'.
- `min` (Number) Minimum number of nodes in the machine pool. This is used for autoscaling the machine pool.
- `node` (Block List) (see [below for nested schema](#nestedblock--machine_pool--node))
- `node_repave_interval` (Number) Minimum number of seconds node should be Ready, before the next node is selected for repave. Default value is `0`, Applicable only for worker pools.
Expand Down
2 changes: 1 addition & 1 deletion docs/resources/cluster_edge_native.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ description: |-
Optional:

- `ntp_servers` (Set of String) A list of NTP servers to be used by the cluster.
- `ssh_key` (String) SSH Key (Secure Shell) to establish, administer, and communicate with remote clusters, `ssh_key & ssh_keys` are mutually exclusive.
- `ssh_key` (String, Deprecated) SSH Key (Secure Shell) to establish, administer, and communicate with remote clusters, `ssh_key & ssh_keys` are mutually exclusive.
- `ssh_keys` (Set of String) List of SSH (Secure Shell) to establish, administer, and communicate with remote clusters, `ssh_key & ssh_keys` are mutually exclusive.
- `vip` (String)

Expand Down
4 changes: 2 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ require (
github.com/hashicorp/terraform-plugin-docs v0.13.0
github.com/hashicorp/terraform-plugin-sdk/v2 v2.26.1
github.com/robfig/cron v1.2.0
github.com/spectrocloud/hapi v1.14.1-0.20231108072852-2b026151dc2b
github.com/spectrocloud/palette-sdk-go v0.0.0-20231107202333-9dc15e23a2b7
github.com/spectrocloud/hapi v1.14.1-0.20231109170830-6909cd3bfc96
github.com/spectrocloud/palette-sdk-go v0.0.0-20231109163311-4c5cb4f433f0
github.com/stretchr/testify v1.8.0
gotest.tools v2.2.0+incompatible
k8s.io/api v0.23.5
Expand Down
4 changes: 4 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -724,8 +724,12 @@ github.com/spectrocloud/gomi v1.14.1-0.20231018185613-210a5f32e20a h1:fIRwPG93qu
github.com/spectrocloud/gomi v1.14.1-0.20231018185613-210a5f32e20a/go.mod h1:5T1lnweC0UQVJcswAguAC8o/gLaaumVL7+PvgP9LVLc=
github.com/spectrocloud/hapi v1.14.1-0.20231108072852-2b026151dc2b h1:eVjj1vNf24rdj2ZbdEfWlnXpOX0qQv10Ow2rozqr4FQ=
github.com/spectrocloud/hapi v1.14.1-0.20231108072852-2b026151dc2b/go.mod h1:Krk9mzbO1MnUTLvvzztBYpOWCFunIlSDWSGlsLh1vkk=
github.com/spectrocloud/hapi v1.14.1-0.20231109170830-6909cd3bfc96 h1:5JDv3DlxzlvfNwdBr/pPs5zkELItq+81QaHa6xyxiOU=
github.com/spectrocloud/hapi v1.14.1-0.20231109170830-6909cd3bfc96/go.mod h1:Krk9mzbO1MnUTLvvzztBYpOWCFunIlSDWSGlsLh1vkk=
github.com/spectrocloud/palette-sdk-go v0.0.0-20231107202333-9dc15e23a2b7 h1:rjl+HdRoAby6qG2zHDxqXbnffaTWNfPWnYH0yYo33FE=
github.com/spectrocloud/palette-sdk-go v0.0.0-20231107202333-9dc15e23a2b7/go.mod h1:PTReFntQs5LWlTbV+SkyJqoj1GtQKKSWXEsNBQ+62XY=
github.com/spectrocloud/palette-sdk-go v0.0.0-20231109163311-4c5cb4f433f0 h1:tLGLxOtFku0ZPjmpksVmAn7Dd1CiYPuc1AQqPcKpGII=
github.com/spectrocloud/palette-sdk-go v0.0.0-20231109163311-4c5cb4f433f0/go.mod h1:FW1lTIjiia2VWxPt6NjUTDmFwOyFJ2r7L5aQc8dEBg0=
github.com/spf13/afero v1.1.2/go.mod h1:j4pytiNVoe2o6bmDsKpLACNPDBIoEAkihy7loJ1B0CQ=
github.com/spf13/afero v1.2.2/go.mod h1:9ZxEEn6pIJ8Rxe320qSDBk6AsU0r9pR7Q4OcevTdifk=
github.com/spf13/afero v1.6.0/go.mod h1:Ai8FlHk4v/PARR026UzYexafAt9roJ7LcLMAmO6Z93I=
Expand Down
1 change: 1 addition & 0 deletions spectrocloud/resource_cluster_edge_native.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ func resourceClusterEdgeNative() *schema.Resource {
"ssh_key": {
Type: schema.TypeString,
Optional: true,
Deprecated: "This field is deprecated from provider 0.16.0. And will be removed in 0.17.0. Use `ssh_keys` instead.",
Description: "SSH Key (Secure Shell) to establish, administer, and communicate with remote clusters, `ssh_key & ssh_keys` are mutually exclusive.",
},
"ssh_keys": {
Expand Down

0 comments on commit f27e849

Please sign in to comment.