docs: cluster scanner first commit #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addetz
reviewed
Oct 29, 2024
Co-authored-by: Adelina Simion <[email protected]>
karl-cardenas-coding
approved these changes
Nov 15, 2024
| if err != nil { | ||
| return nil, err | ||
| } | ||
| message := fmt.Sprintf("The %s cluster named %s has been running for %s. Are you sure you need this cluster?", cluster.SpecSummary.CloudConfig.CloudType, cluster.Metadata.Name, *age) |
There was a problem hiding this comment.
Food for thought. Say you have lots of clusters that are past 24 hrs in age. Do you want the output to include the "Are you sure you need this cluster?" in every line?
Comment on lines
+19
to
+27
| weeks := hoursAge / hoursPerWeek | ||
| remainingHours := hoursAge - weeks*hoursPerWeek | ||
| days := remainingHours / 24 | ||
| hours := remainingHours % 24 | ||
| return &FormattedAge{ | ||
| Days: days, | ||
| Weeks: weeks, | ||
| Hours: hours, | ||
| }, nil |
| found := false | ||
| for _, want := range value.output { | ||
| if got == want { | ||
| found = true |
There was a problem hiding this comment.
You could make the argument the assignment here plays no purpose. The reason I say that is because you immediately return, so nothing ever uses it if it's ever true.
Suggested change
| found = true | |
| found = true |
| // Iterate through the clusters to find those running for more than 24 hours | ||
| for _, cluster := range clusters { | ||
| timeValue := time.Time(cluster.Metadata.CreationTimestamp) | ||
| clusterAge := time.Now().Sub(timeValue) |
There was a problem hiding this comment.
This is 100% valid - but if you want to be hip ✨, then you can use the new function released recently time.Since(t)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Change
This PR adds a tool that uses the Palette Go SDK to find clusters running for more than 24 hours.
Checklist
README updated?
Content added contains comments that explain the purpose of the script and usage.