-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new pack - Hello Universe - 1.0.0 #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great start and easy to follow. I just have some suggestions below that will make it easier for users to use the pack down the road 😄
Here are a few updates: I've addressed the review comments, added the content section to the values.yaml file after talking to Vishwanath, included a schema.yaml file, and updated the manifest and values.yaml file so that they look similar to other packs. The Hello Universe pack was tested using a local registry and a VMware cluster, and all checks of this repo have passed. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - Just one minor suggestion that I missed with my previous code snippet.
Co-authored-by: Karl Cardenas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 🚀
Describe the Change
This PR includes the Hello Universe pack to the SpectroCloud community repo. This is a requirement of the upcoming PCG tutorial.
Hello Universe is a demo web application utilized to help users learn more about Palette and its features.