Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new pack - Hello Universe - 1.0.0 #60

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Conversation

caroldelwing
Copy link
Contributor

Describe the Change

This PR includes the Hello Universe pack to the SpectroCloud community repo. This is a requirement of the upcoming PCG tutorial.
Hello Universe is a demo web application utilized to help users learn more about Palette and its features.

Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great start and easy to follow. I just have some suggestions below that will make it easier for users to use the pack down the road 😄

packs/hello-universe-1.0.0/logo.png Outdated Show resolved Hide resolved
packs/hello-universe-1.0.0/manifests/hello-universe.yaml Outdated Show resolved Hide resolved
packs/hello-universe-1.0.0/manifests/hello-universe.yaml Outdated Show resolved Hide resolved
packs/hello-universe-1.0.0/pack.json Outdated Show resolved Hide resolved
packs/hello-universe-1.0.0/README.md Outdated Show resolved Hide resolved
packs/hello-universe-1.0.0/README.md Outdated Show resolved Hide resolved
packs/hello-universe-1.0.0/README.md Outdated Show resolved Hide resolved
packs/hello-universe-1.0.0/manifests/hello-universe.yaml Outdated Show resolved Hide resolved
@caroldelwing
Copy link
Contributor Author

Here are a few updates: I've addressed the review comments, added the content section to the values.yaml file after talking to Vishwanath, included a schema.yaml file, and updated the manifest and values.yaml file so that they look similar to other packs. The Hello Universe pack was tested using a local registry and a VMware cluster, and all checks of this repo have passed. :)

@caroldelwing caroldelwing marked this pull request as ready for review February 26, 2024 14:53
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - Just one minor suggestion that I missed with my previous code snippet.

packs/hello-universe-1.1.1/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🚀

@brathina-spectro brathina-spectro merged commit 47c86e2 into main Feb 27, 2024
2 checks passed
@brathina-spectro brathina-spectro deleted the hello-universe branch February 27, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants