return Option<&T> instead of &Option<T>

specta-rs · Sep 3, 2023 · e1cee74 · e1cee74
1 parent 5948d80
commit e1cee74
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/datatype/named.rs b/src/datatype/named.rs
@@ -24,8 +24,8 @@ impl NamedDataTypeExt {
         &self.impl_location
     }
 
-    pub fn export(&self) -> &Option<bool> {
-        &self.export
+    pub fn export(&self) -> Option<bool> {
+        self.export
     }
 }
 
@@ -55,12 +55,12 @@ impl NamedDataType {
         &self.comments
     }
 
-    pub fn deprecated(&self) -> &Option<Cow<'static, str>> {
-        &self.deprecated
+    pub fn deprecated(&self) -> Option<&Cow<'static, str>> {
+        self.deprecated.as_ref()
     }
 
-    pub fn ext(&self) -> &Option<NamedDataTypeExt> {
-        &self.ext
+    pub fn ext(&self) -> Option<&NamedDataTypeExt> {
+        self.ext.as_ref()
     }
 }
 

diff --git a/src/datatype/struct.rs b/src/datatype/struct.rs
@@ -65,8 +65,8 @@ impl StructType {
         self.fields.iter()
     }
 
-    pub fn tag(&self) -> &Option<Cow<'static, str>> {
-        &self.tag
+    pub fn tag(&self) -> Option<&Cow<'static, str>> {
+        self.tag.as_ref()
     }
 }