Skip to content

Datatype Copy Rust's Structure #193

Datatype Copy Rust's Structure

Datatype Copy Rust's Structure #193

Triggered via pull request September 3, 2023 05:25
Status Success
Total duration 11m 53s
Artifacts

ci.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

101 warnings
missing documentation for a function: src/type/mod.rs#L106
warning: missing documentation for a function --> src/type/mod.rs:106:5 | 106 | / pub fn reference<T: NamedType>( 107 | | opts: DefOpts, 108 | | generics: &[DataType], 109 | | reference: DataTypeReference, 110 | | ) -> Result<Reference> { | |__________________________^
missing documentation for a function: src/type/mod.rs#L99
warning: missing documentation for a function --> src/type/mod.rs:99:5 | 99 | pub fn inline<T: Type + ?Sized>(opts: DefOpts, generics: &[DataType]) -> Result<Reference> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a struct field: src/type/mod.rs#L95
warning: missing documentation for a struct field --> src/type/mod.rs:95:9 | 95 | pub inner: DataType, | ^^^^^^^^^^^^^^^^^^^
missing documentation for an associated constant: src/type/mod.rs#L70
warning: missing documentation for an associated constant --> src/type/mod.rs:70:5 | 70 | const IMPL_LOCATION: ImplLocation; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for an associated constant: src/type/mod.rs#L69
warning: missing documentation for an associated constant --> src/type/mod.rs:69:5 | 69 | const SID: SpectaID; | ^^^^^^^^^^^^^^^^^^^
missing documentation for a variant: src/type/mod.rs#L21
warning: missing documentation for a variant --> src/type/mod.rs:21:5 | 21 | InvalidType(ImplLocation, &'static str), | ^^^^^^^^^^^
missing documentation for a type alias: src/type/mod.rs#L14
warning: missing documentation for a type alias --> src/type/mod.rs:14:1 | 14 | pub type Result<T> = std::result::Result<T, ExportError>; | ^^^^^^^^^^^^^^^^^^
useless conversion to the same type: `datatype::r#enum::EnumType`: src/type/impls.rs#L294
warning: useless conversion to the same type: `datatype::r#enum::EnumType` --> src/type/impls.rs:294:17 | 294 | / EnumType { 295 | | name: "Number".into(), 296 | | taging: EnumTag::Untagged, 297 | | variants: vec![ ... | 315 | | } 316 | | .into(), | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into()` | 294 ~ EnumType { 295 + name: "Number".into(), 296 + taging: EnumTag::Untagged, 297 + variants: vec![ 298 + EnumVariant::Unnamed(EnumUnnamedFields { 299 + name: "f64".into(), 300 + fields: vec![DataType::Primitive(PrimitiveType::f64)], 301 + generics: vec![], 302 + }), 303 + EnumVariant::Unnamed(EnumUnnamedFields { 304 + name: "i64".into(), 305 + fields: vec![DataType::Primitive(PrimitiveType::i64)], 306 + generics: vec![], 307 + }), 308 + EnumVariant::Unnamed(EnumUnnamedFields { 309 + name: "u64".into(), 310 + fields: vec![DataType::Primitive(PrimitiveType::u64)], 311 + generics: vec![], 312 + }), 313 + ], 314 + generics: vec![], 315 ~ }, |
useless conversion to the same type: `datatype::r#enum::EnumType`: src/type/impls.rs#L243
warning: useless conversion to the same type: `datatype::r#enum::EnumType` --> src/type/impls.rs:243:17 | 243 | / EnumType { 244 | | name: "Number".into(), 245 | | taging: EnumTag::Untagged, 246 | | variants: vec![ ... | 264 | | } 265 | | .into(), | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into()` | 243 ~ EnumType { 244 + name: "Number".into(), 245 + taging: EnumTag::Untagged, 246 + variants: vec![ 247 + EnumVariant::Unnamed(EnumUnnamedFields { 248 + name: "f64".into(), 249 + fields: vec![DataType::Primitive(PrimitiveType::f64)], 250 + generics: vec![], 251 + }), 252 + EnumVariant::Unnamed(EnumUnnamedFields { 253 + name: "i64".into(), 254 + fields: vec![DataType::Primitive(PrimitiveType::i64)], 255 + generics: vec![], 256 + }), 257 + EnumVariant::Unnamed(EnumUnnamedFields { 258 + name: "u64".into(), 259 + fields: vec![DataType::Primitive(PrimitiveType::u64)], 260 + generics: vec![], 261 + }), 262 + ], 263 + generics: vec![], 264 ~ }, |
this expression creates a reference which is immediately dereferenced by the compiler: src/lang/ts/mod.rs#L438
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/lang/ts/mod.rs:438:33 | 438 | ... &v, | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: src/lang/ts/mod.rs#L425
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/lang/ts/mod.rs:425:33 | 425 | ... &v, | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
length comparison to zero: src/lang/ts/mod.rs#L375
warning: length comparison to zero --> src/lang/ts/mod.rs:375:8 | 375 | if e.variants().len() == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `e.variants().is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
useless use of `format!`: src/lang/ts/mod.rs#L367
warning: useless use of `format!` --> src/lang/ts/mod.rs:367:22 | 367 | 1 => format!("{}", fields[0]), | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `fields[0].to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `#[warn(clippy::useless_format)]` implied by `#[warn(clippy::all)]`
length comparison to zero: src/lang/ts/mod.rs#L294
warning: length comparison to zero --> src/lang/ts/mod.rs:294:16 | 294 | if s.fields.len() == 0 { | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.fields.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `#[warn(clippy::len_zero)]` implied by `#[warn(clippy::all)]`
unneeded `return` statement: src/lang/ts/mod.rs#L291
warning: unneeded `return` statement --> src/lang/ts/mod.rs:291:29 | 291 | StructType::Unit => return Ok("null".into()), | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` implied by `#[warn(clippy::all)]` help: remove `return` | 291 | StructType::Unit => Ok("null".into()), | ~~~~~~~~~~~~~~~~~
this match could be written as a `let` statement: src/lang/ts/mod.rs#L274
warning: this match could be written as a `let` statement --> src/lang/ts/mod.rs:274:5 | 274 | / match tuple { 275 | | TupleType { fields, .. } => match &fields[..] { 276 | | [] => Ok(empty_tuple_fallback.to_string()), 277 | | [ty] => datatype_inner(ctx, ty, type_map, "null"), ... | 285 | | }, 286 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding = note: `#[warn(clippy::match_single_binding)]` implied by `#[warn(clippy::all)]` help: consider using a `let` statement | 274 ~ let TupleType { fields, .. } = tuple; 275 + match &fields[..] { 276 + [] => Ok(empty_tuple_fallback.to_string()), 277 + [ty] => datatype_inner(ctx, ty, type_map, "null"), 278 + tys => Ok(format!( 279 + "[{}]", 280 + tys.iter() 281 + .map(|v| datatype_inner(ctx.clone(), v, type_map, "null")) 282 + .collect::<Result<Vec<_>>>()? 283 + .join(", ") 284 + )), 285 + } |
writing `&Vec` instead of `&[_]` involves a new object where a slice will do: src/lang/ts/mod.rs#L251
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> src/lang/ts/mod.rs:251:13 | 251 | fields: &Vec<DataType>, | ^^^^^^^^^^^^^^ help: change this to: `&[DataType]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` implied by `#[warn(clippy::all)]`
`panic` should not be present in production code: src/lang/ts/mod.rs#L176
warning: `panic` should not be present in production code --> src/lang/ts/mod.rs:176:44 | 176 | .unwrap_or_else(|| panic!("Type {} has no value!", r.name())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic
`panic` should not be present in production code: src/lang/ts/mod.rs#L174
warning: `panic` should not be present in production code --> src/lang/ts/mod.rs:174:44 | 174 | .unwrap_or_else(|| panic!("Type {} not found!", r.name())) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic note: the lint level is defined here --> src/lib.rs:58:43 | 58 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic, missing_docs)] | ^^^^^^^^^^^^^
missing documentation for a variant: src/lang/ts/error.rs#L48
warning: missing documentation for a variant --> src/lang/ts/error.rs:48:5 | 48 | Other(ExportPath, String), | ^^^^^
missing documentation for a variant: src/lang/ts/error.rs#L46
warning: missing documentation for a variant --> src/lang/ts/error.rs:46:5 | 46 | Io(#[from] std::io::Error), | ^^
missing documentation for a variant: src/lang/ts/error.rs#L44
warning: missing documentation for a variant --> src/lang/ts/error.rs:44:5 | 44 | SpectaExportError(#[from] ExportError), | ^^^^^^^^^^^^^^^^^
missing documentation for a variant: src/lang/ts/error.rs#L42
warning: missing documentation for a variant --> src/lang/ts/error.rs:42:5 | 42 | DuplicateTypeName(Cow<'static, str>, ImplLocation, ImplLocation), | ^^^^^^^^^^^^^^^^^
missing documentation for a variant: src/lang/ts/error.rs#L40
warning: missing documentation for a variant --> src/lang/ts/error.rs:40:5 | 40 | InvalidTagging(ExportPath), | ^^^^^^^^^^^^^^
missing documentation for a variant: src/lang/ts/error.rs#L38
warning: missing documentation for a variant --> src/lang/ts/error.rs:38:5 | 38 | ForbiddenName(NamedLocation, ExportPath, &'static str), | ^^^^^^^^^^^^^
missing documentation for a variant: src/lang/ts/error.rs#L34
warning: missing documentation for a variant --> src/lang/ts/error.rs:34:5 | 34 | BigIntForbidden(ExportPath), | ^^^^^^^^^^^^^^^
useless conversion to the same type: `export::export::TypesIter`: src/export/ts.rs#L19
warning: useless conversion to the same type: `export::export::TypesIter` --> src/export/ts.rs:19:17 | 19 | let types = get_types()? | _________________^ 20 | | .into_iter() | |____________________^ help: consider removing `.into_iter()`: `get_types()?` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `r#type::ExportError`: src/export/export.rs#L38
warning: useless conversion to the same type: `r#type::ExportError` --> src/export/export.rs:38:20 | 38 | return Err(err.clone().into()); | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `err.clone()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
module has the same name as its containing module: src/export/mod.rs#L1
warning: module has the same name as its containing module --> src/export/mod.rs:1:1 | 1 | mod export; | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` implied by `#[warn(clippy::all)]`
useless conversion to the same type: `datatype::r#enum::EnumType`: src/datatype/mod.rs#L130
warning: useless conversion to the same type: `datatype::r#enum::EnumType` --> src/datatype/mod.rs:130:13 | 130 | / EnumType { 131 | | name: "Vec".into(), 132 | | taging: EnumTag::Untagged, 133 | | variants: t ... | 149 | | } 150 | | .into(), | |___________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` implied by `#[warn(clippy::all)]` help: consider removing `.into()` | 130 ~ EnumType { 131 + name: "Vec".into(), 132 + taging: EnumTag::Untagged, 133 + variants: t 134 + .into_iter() 135 + .map(|t| { 136 + let dt: DataType = t.into(); 137 + EnumVariant::Unnamed(EnumUnnamedFields { 138 + name: match &dt { 139 + DataType::Struct(StructType::Named(s)) => s.name.clone(), 140 + DataType::Enum(e) => e.name().clone(), 141 + _ => "".into(), 142 + }, 143 + fields: vec![dt], 144 + generics: vec![], 145 + }) 146 + }) 147 + .collect(), 148 + generics: vec![], 149 ~ }, |
missing documentation for a method: src/datatype/mod.rs#L96
warning: missing documentation for a method --> src/datatype/mod.rs:96:5 | 96 | pub fn generics(&self) -> impl Iterator<Item = &DataType> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/mod.rs#L92
warning: missing documentation for a method --> src/datatype/mod.rs:92:5 | 92 | pub fn sid(&self) -> SpectaID { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/mod.rs#L88
warning: missing documentation for a method --> src/datatype/mod.rs:88:5 | 88 | pub fn name(&self) -> &Cow<'static, str> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/mod.rs#L62
warning: missing documentation for a method --> src/datatype/mod.rs:62:5 | 62 | pub fn generics(&self) -> Option<Vec<GenericType>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/tuple.rs#L33
warning: missing documentation for a method --> src/datatype/tuple.rs:33:5 | 33 | pub fn fields(&self) -> impl Iterator<Item = &DataType> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/struct.rs#L146
warning: missing documentation for a method --> src/datatype/struct.rs:146:5 | 146 | pub fn tag(&self) -> Option<&Cow<'static, str>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/struct.rs#L127
warning: missing documentation for a method --> src/datatype/struct.rs:127:5 | 127 | pub fn fields(&self) -> Vec<StructField> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/struct.rs#L119
warning: missing documentation for a method --> src/datatype/struct.rs:119:5 | 119 | pub fn generics(&self) -> Vec<GenericType> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for an enum: src/datatype/struct.rs#L85
warning: missing documentation for an enum --> src/datatype/struct.rs:85:1 | 85 | pub enum StructType { | ^^^^^^^^^^^^^^^^^^^
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: src/datatype/struct.rs#L78
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/datatype/struct.rs:78:1 | 78 | impl Into<StructType> for StructNamedFields { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into help: replace the `Into` implementation with `From<datatype::r#struct::StructNamedFields>` | 78 ~ impl From<StructNamedFields> for StructType { 79 ~ fn from(val: StructNamedFields) -> Self { 80 ~ StructType::Named(val) |
missing documentation for a method: src/datatype/struct.rs#L73
warning: missing documentation for a method --> src/datatype/struct.rs:73:5 | 73 | pub fn tag(&self) -> &Option<Cow<'static, str>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/struct.rs#L69
warning: missing documentation for a method --> src/datatype/struct.rs:69:5 | 69 | pub fn fields(&self) -> impl Iterator<Item = &StructField> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/struct.rs#L65
warning: missing documentation for a method --> src/datatype/struct.rs:65:5 | 65 | pub fn generics(&self) -> impl Iterator<Item = &GenericType> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a struct: src/datatype/struct.rs#L57
warning: missing documentation for a struct --> src/datatype/struct.rs:57:1 | 57 | pub struct StructNamedFields { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: src/datatype/struct.rs#L50
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/datatype/struct.rs:50:1 | 50 | impl Into<StructType> for StructUnnamedFields { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `#[warn(clippy::from_over_into)]` implied by `#[warn(clippy::all)]` help: replace the `Into` implementation with `From<datatype::r#struct::StructUnnamedFields>` | 50 ~ impl From<StructUnnamedFields> for StructType { 51 ~ fn from(val: StructUnnamedFields) -> Self { 52 ~ StructType::Unnamed(val) |
missing documentation for a method: src/datatype/struct.rs#L40
warning: missing documentation for a method --> src/datatype/struct.rs:40:5 | 40 | pub fn generics(&self) -> impl Iterator<Item = &GenericType> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a struct: src/datatype/struct.rs#L33
warning: missing documentation for a struct --> src/datatype/struct.rs:33:1 | 33 | pub struct StructUnnamedFields { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/struct.rs#L27
warning: missing documentation for a method --> src/datatype/struct.rs:27:5 | 27 | pub fn ty(&self) -> &DataType { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/struct.rs#L23
warning: missing documentation for a method --> src/datatype/struct.rs:23:5 | 23 | pub fn flatten(&self) -> bool { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/struct.rs#L19
warning: missing documentation for a method --> src/datatype/struct.rs:19:5 | 19 | pub fn optional(&self) -> bool { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/struct.rs#L15
warning: missing documentation for a method --> src/datatype/struct.rs:15:5 | 15 | pub fn key(&self) -> &Cow<'static, str> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a variant: src/datatype/primitive.rs#L23
warning: missing documentation for a variant --> src/datatype/primitive.rs:23:5 | 23 | String, | ^^^^^^
missing documentation for a variant: src/datatype/primitive.rs#L22
warning: missing documentation for a variant --> src/datatype/primitive.rs:22:5 | 22 | char, | ^^^^
missing documentation for a variant: src/datatype/primitive.rs#L21
warning: missing documentation for a variant --> src/datatype/primitive.rs:21:5 | 21 | bool, | ^^^^
missing documentation for a variant: src/datatype/primitive.rs#L20
warning: missing documentation for a variant --> src/datatype/primitive.rs:20:5 | 20 | f64, | ^^^
missing documentation for a variant: src/datatype/primitive.rs#L19
warning: missing documentation for a variant --> src/datatype/primitive.rs:19:5 | 19 | f32, | ^^^
missing documentation for a variant: src/datatype/primitive.rs#L18
warning: missing documentation for a variant --> src/datatype/primitive.rs:18:5 | 18 | usize, | ^^^^^
missing documentation for a variant: src/datatype/primitive.rs#L17
warning: missing documentation for a variant --> src/datatype/primitive.rs:17:5 | 17 | u128, | ^^^^
missing documentation for a variant: src/datatype/primitive.rs#L16
warning: missing documentation for a variant --> src/datatype/primitive.rs:16:5 | 16 | u64, | ^^^
missing documentation for a variant: src/datatype/primitive.rs#L15
warning: missing documentation for a variant --> src/datatype/primitive.rs:15:5 | 15 | u32, | ^^^
missing documentation for a variant: src/datatype/primitive.rs#L14
warning: missing documentation for a variant --> src/datatype/primitive.rs:14:5 | 14 | u16, | ^^^
missing documentation for a variant: src/datatype/primitive.rs#L13
warning: missing documentation for a variant --> src/datatype/primitive.rs:13:5 | 13 | u8, | ^^
missing documentation for a variant: src/datatype/primitive.rs#L12
warning: missing documentation for a variant --> src/datatype/primitive.rs:12:5 | 12 | isize, | ^^^^^
missing documentation for a variant: src/datatype/primitive.rs#L11
warning: missing documentation for a variant --> src/datatype/primitive.rs:11:5 | 11 | i128, | ^^^^
missing documentation for a variant: src/datatype/primitive.rs#L10
warning: missing documentation for a variant --> src/datatype/primitive.rs:10:5 | 10 | i64, | ^^^
missing documentation for a variant: src/datatype/primitive.rs#L9
warning: missing documentation for a variant --> src/datatype/primitive.rs:9:5 | 9 | i32, | ^^^
missing documentation for a variant: src/datatype/primitive.rs#L8
warning: missing documentation for a variant --> src/datatype/primitive.rs:8:5 | 8 | i16, | ^^^
missing documentation for a variant: src/datatype/primitive.rs#L7
warning: missing documentation for a variant --> src/datatype/primitive.rs:7:5 | 7 | i8, | ^^
missing documentation for a method: src/datatype/named.rs#L62
warning: missing documentation for a method --> src/datatype/named.rs:62:5 | 62 | pub fn ext(&self) -> &Option<NamedDataTypeExt> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/named.rs#L58
warning: missing documentation for a method --> src/datatype/named.rs:58:5 | 58 | pub fn deprecated(&self) -> &Option<Cow<'static, str>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/named.rs#L54
warning: missing documentation for a method --> src/datatype/named.rs:54:5 | 54 | pub fn comments(&self) -> &Vec<Cow<'static, str>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/named.rs#L50
warning: missing documentation for a method --> src/datatype/named.rs:50:5 | 50 | pub fn name(&self) -> &Cow<'static, str> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/named.rs#L27
warning: missing documentation for a method --> src/datatype/named.rs:27:5 | 27 | pub fn export(&self) -> &Option<bool> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/named.rs#L23
warning: missing documentation for a method --> src/datatype/named.rs:23:5 | 23 | pub fn impl_location(&self) -> &ImplLocation { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/named.rs#L19
warning: missing documentation for a method --> src/datatype/named.rs:19:5 | 19 | pub fn sid(&self) -> &SpectaID { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
this expression creates a reference which is immediately dereferenced by the compiler: src/datatype/enum.rs#L165
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/datatype/enum.rs:165:33 | 165 | Self::Unit(name) => &name, | ^^^^^ help: change this to: `name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` implied by `#[warn(clippy::all)]`
missing documentation for a method: src/datatype/enum.rs#L163
warning: missing documentation for a method --> src/datatype/enum.rs:163:5 | 163 | pub fn name(&self) -> &Cow<'static, str> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/enum.rs#L152
warning: missing documentation for a method --> src/datatype/enum.rs:152:5 | 152 | pub fn generics(&self) -> impl Iterator<Item = &GenericType> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a struct: src/datatype/enum.rs#L145
warning: missing documentation for a struct --> src/datatype/enum.rs:145:1 | 145 | pub struct EnumUnnamedFields { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a type alias: src/datatype/enum.rs#L142
warning: missing documentation for a type alias --> src/datatype/enum.rs:142:1 | 142 | pub type EnumNamedFields = StructNamedFields; | ^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a variant: src/datatype/enum.rs#L138
warning: missing documentation for a variant --> src/datatype/enum.rs:138:5 | 138 | Unnamed(EnumUnnamedFields), | ^^^^^^^
missing documentation for a variant: src/datatype/enum.rs#L137
warning: missing documentation for a variant --> src/datatype/enum.rs:137:5 | 137 | Named(StructNamedFields), | ^^^^^
missing documentation for a variant: src/datatype/enum.rs#L136
warning: missing documentation for a variant --> src/datatype/enum.rs:136:5 | 136 | Unit(Cow<'static, str>), | ^^^^
missing documentation for a variant: src/datatype/enum.rs#L130
warning: missing documentation for a variant --> src/datatype/enum.rs:130:5 | 130 | Tagged(EnumRepr), | ^^^^^^
missing documentation for a variant: src/datatype/enum.rs#L129
warning: missing documentation for a variant --> src/datatype/enum.rs:129:5 | 129 | Untagged, | ^^^^^^^^
missing documentation for an enum: src/datatype/enum.rs#L128
warning: missing documentation for an enum --> src/datatype/enum.rs:128:1 | 128 | pub enum EnumTag { | ^^^^^^^^^^^^^^^^
missing documentation for a struct field: src/datatype/enum.rs#L123
warning: missing documentation for a struct field --> src/datatype/enum.rs:123:9 | 123 | content: Cow<'static, str>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a struct field: src/datatype/enum.rs#L122
warning: missing documentation for a struct field --> src/datatype/enum.rs:122:9 | 122 | tag: Cow<'static, str>, | ^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a variant: src/datatype/enum.rs#L121
warning: missing documentation for a variant --> src/datatype/enum.rs:121:5 | 121 | Adjacent { | ^^^^^^^^
missing documentation for a struct field: src/datatype/enum.rs#L119
warning: missing documentation for a struct field --> src/datatype/enum.rs:119:9 | 119 | tag: Cow<'static, str>, | ^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a variant: src/datatype/enum.rs#L118
warning: missing documentation for a variant --> src/datatype/enum.rs:118:5 | 118 | Internal { | ^^^^^^^^
missing documentation for a variant: src/datatype/enum.rs#L117
warning: missing documentation for a variant --> src/datatype/enum.rs:117:5 | 117 | External, | ^^^^^^^^
missing documentation for a method: src/datatype/enum.rs#L53
warning: missing documentation for a method --> src/datatype/enum.rs:53:5 | 53 | pub fn generics(&self) -> &Vec<GenericType> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/enum.rs#L49
warning: missing documentation for a method --> src/datatype/enum.rs:49:5 | 49 | pub fn variants(&self) -> &Vec<EnumVariant> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/enum.rs#L45
warning: missing documentation for a method --> src/datatype/enum.rs:45:5 | 45 | pub fn taging(&self) -> &EnumTag { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing documentation for a method: src/datatype/enum.rs#L41
warning: missing documentation for a method --> src/datatype/enum.rs:41:5 | 41 | pub fn name(&self) -> &Cow<'static, str> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: the lint level is defined here --> src/lib.rs:58:58 | 58 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic, missing_docs)] | ^^^^^^^^^^^^
constant `RESERVED_IDENTS` is never used: src/lang/ts/reserved_terms.rs#L66
warning: constant `RESERVED_IDENTS` is never used --> src/lang/ts/reserved_terms.rs:66:18 | 66 | pub(super) const RESERVED_IDENTS: &[&str] = &[ | ^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
unneeded unit return type: src/export/export.rs#L49
warning: unneeded unit return type --> src/export/export.rs:49:30 | 49 | pub fn register_ty<T: Type>() -> () { | ^^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit note: the lint level is defined here --> src/lib.rs:58:9 | 58 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic, missing_docs)] | ^^^^^^^^^^^ = note: `#[warn(clippy::unused_unit)]` implied by `#[warn(clippy::all)]`
unused import: `crate::ts::TsExportError`: src/export/export.rs#L1
warning: unused import: `crate::ts::TsExportError` --> src/export/export.rs:1:5 | 1 | use crate::ts::TsExportError; | ^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `StructUnnamedFields`: src/datatype/enum.rs#L5
warning: unused import: `StructUnnamedFields` --> src/datatype/enum.rs:5:5 | 5 | StructUnnamedFields, | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/