This repository has been archived by the owner on May 6, 2020. It is now read-only.
forked from grevit-dev/Grevit
-
Notifications
You must be signed in to change notification settings - Fork 0
Dimitrie/dev/integrations #12
Open
didimitrie
wants to merge
22
commits into
master
Choose a base branch
from
Dimitrie/dev/integrations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stream to grevit objs in revit (see #4). changelog: - adds speckle core as a reference - adds a speckle command - receives objects from a speckle stream
- added ext event & all the boilerplate re external commands etc. - now setting grevit scale automagically from speckle stream base props
Merge commit '6009b3306ba49b738e28334421e9a0d5ea0cc717' into Dimitrie/dev/integrations * commit '6009b3306ba49b738e28334421e9a0d5ea0cc717': fixed download icon and login logic when no account exists
…tream (they get re-baked on click)
# Conflicts: # SpeckleClientUI/Receiver.cs # SpeckleClientUI/ReceiversUi.xaml.cs # SpeckleClientUI/SpeckleClientUI.csproj
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is purely a conversation starter. It's a bit of a mess, but most of the speckle-needed pieces are inside (only tested on revit 2019).
Ie: @teocomi strapped a nice WPF UI that you can retrieve streams from; I've wrangled a bit the grevit-backend logic to make component creation not reliant on a static class anymore. Unit conversions are done automagically by stream.
Also kind-of implemented a proper diffing logic based on the speckle objects (& now the grevit components
GID
is set to be the speckle objects's hash), so "baking" a speckle stream containing grevit objects will not duplicate things & take into account previous user-deleted objects.The whole revit integration with external command handlers, etc. needs to be rethought.