Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added newer DefaultTraversal rules to align with V3 sharp connectors #367

Merged
merged 4 commits into from
Feb 3, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated traversal
JR-Morgan committed Jan 24, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 17fb320f20da6ccb329c1f3f76144764d6cea680
3 changes: 2 additions & 1 deletion src/specklepy/objects/graph_traversal/default_traversal.py
Original file line number Diff line number Diff line change
@@ -21,7 +21,8 @@ def create_default_traversal_function() -> GraphTraversal:

default_rule = TraversalRule(
[lambda _: True],
lambda o: o.get_member_names(), # NOTE: Unlike the C# implementation, this does not ignore Obsolete members
# NOTE: Unlike the C# implementation, this does not ignore Obsolete members
lambda o: o.get_member_names(),
False,
)

1 change: 0 additions & 1 deletion src/specklepy/objects/graph_traversal/traversal.py
Original file line number Diff line number Diff line change
@@ -7,7 +7,6 @@


class ITraversalRule(Protocol):

@property
def should_return(self) -> bool:
pass
8 changes: 3 additions & 5 deletions tests/unit/test_traverse_value.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from typing import List
from dataclasses import dataclass
from typing import List

from specklepy.objects.base import Base
from specklepy.serialization.base_object_serializer import BaseObjectSerializer
@@ -12,16 +12,14 @@ class FakeBase(Base):


def test_traverse_value():
base = FakeBase(bar=1)
base.foo = [None]
base = FakeBase(bar=1, foo=["abcd"])
serializer = BaseObjectSerializer()
object_id, object_dict = serializer.traverse_base(base)
assert object_dict == {
"id": object_id,
"speckle_type": "Tests.Unit.TestTraverseValue.FakeBase",
"applicationId": None,
"foo": [None],
"units": None,
"foo": ["abcd"],
"bar": 1,
"totalChildrenCount": 0,
}