Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNX 671 Local Axes of Structural Objects #3648

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

bjoernsteinhagen
Copy link
Contributor

@bjoernsteinhagen bjoernsteinhagen commented Oct 30, 2024

Description & motivation

  • orientationAngle is inherint in the Element1D (and inheriting CSIELement1D), but the connectivity is lacking. This is made evident in the connection Revit to ETABS.
  • A cross section rotation applied to analytical members in Revit, does not convert to Speckle (i.e. the orientationAngle is always 0)
  • This results, obviously in no local axis rotations to elements recevied from Revit in ETABS
  • Request supported and requested by the team at Karamba3D

image

image

Changes:

  • Write to the orientationAngle property in the ConvertToSpeckle() from Revit.
  • The result of radians remains as is (assumed to be standard Speckle internal units from what I could see)
  • In ETABS ConvertToNative radians converted to degrees for ETABS' SetLocalAxes

Validation of changes:

Sent from Revit - now has orientationAngle in radians

image

Received in ETABS

image

Disclaimer

  • ETABS does enforce a alignment of local axis to global axis which won't conform to typical FEM right-hand rule. HOWEVER, this is not a Speckle thing. When working with the Analytical Model in Revit, conform to axis alignments.
  • Element2D not included in the scope of this PR

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

CrossSectionRotation parameters of Revit analytical sticks were not assigned to Element1D.orientationAngle, hence not being received in ETABS.
@bjoernsteinhagen bjoernsteinhagen added bug Something isn't working revit issues related to the revit connector. CSI labels Oct 30, 2024
@bjoernsteinhagen bjoernsteinhagen self-assigned this Oct 30, 2024
Copy link

linear bot commented Oct 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CSI revit issues related to the revit connector.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant