Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUI3-38 Clarify and Support valid fallback value types #33

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

clairekuang
Copy link
Member

@clairekuang clairekuang commented Jul 16, 2024

Do not merge - record of Interfacing work done to constrain fallback displayvalue types

Key points:

  • New IBasicGeometryType interface implemented by Point, Line, Polyline, Mesh
  • IDisplayValue updated to only accept IEnumerable<IBasicGeometryType>
  • POC updating classes to new display values - breaking change here for eg classes that were previously not List

Blocking:

  • probably will want to remove structural classes, and GH constructors before making this change
  • discuss IBase first

@clairekuang
Copy link
Member Author

Freeform elements and DirectShapes currently break the assumption that displayValue lists will only have objects of one type: I believe we are supporting display values that are a mix of curves and meshes in these classes.

@JR-Morgan JR-Morgan marked this pull request as draft July 16, 2024 10:18
@JR-Morgan JR-Morgan added this to the Post Beta Launch milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants