Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize now waits for the scheduler to be completed before returning #225

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented Feb 5, 2025

Trying to stop occasional indeterminate tests 😬

Cancellation for download should be snappier as the token is listened to and the stream happens asap with ResponseHeadersRead

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 74.04580% with 34 lines in your changes missing coverage. Please review.

Project coverage is 70.79%. Comparing base (988599f) to head (7f1eef5).

Files with missing lines Patch % Lines
...le.Sdk/Serialisation/V2/SerializeProcessFactory.cs 0.00% 9 Missing ⚠️
...c/Speckle.Sdk/Api/Operations/Operations.Receive.cs 0.00% 8 Missing ⚠️
src/Speckle.Sdk/Api/Operations/Operations.Send.cs 0.00% 8 Missing ⚠️
...peckle.Sdk/Serialisation/V2/ServerObjectManager.cs 0.00% 8 Missing ⚠️
...ckle.Sdk.Serialization.Tests/SerializationTests.cs 95.45% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #225       +/-   ##
===========================================
+ Coverage   59.58%   70.79%   +11.20%     
===========================================
  Files         262      278       +16     
  Lines       10460    11205      +745     
  Branches     1105     1108        +3     
===========================================
+ Hits         6233     7933     +1700     
+ Misses       3964     2918     -1046     
- Partials      263      354       +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock
Copy link
Member Author

I think the empty message ensures all messages are complete and prevents the unstable tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants