Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhino stability fixes #375

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Rhino stability fixes #375

merged 6 commits into from
Nov 8, 2024

Conversation

didimitrie
Copy link
Member

Related to CNX-774: Rhino 8 Deep Crashes

Main fix is to ensure that we're executing delicate operations on the main thread:

  • purging for second send
  • layer creation/deletion

Baking objects in the document is still happening as before.

Copy link

linear bot commented Nov 8, 2024

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 8.39%. Comparing base (b2606d2) to head (37dd3eb).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
....RhinoShared/ToHost/Raw/PolylineToHostConverter.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #375      +/-   ##
========================================
- Coverage   8.40%   8.39%   -0.01%     
========================================
  Files        237     237              
  Lines       4690    4691       +1     
  Branches     512     513       +1     
========================================
  Hits         394     394              
- Misses      4280    4281       +1     
  Partials      16      16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didimitrie didimitrie marked this pull request as ready for review November 8, 2024 16:50
@oguzhankoral oguzhankoral merged commit 5e92889 into dev Nov 8, 2024
5 checks passed
@oguzhankoral oguzhankoral deleted the dim/rh8-stability branch November 8, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants