Skip to content

Commit

Permalink
chore: comments
Browse files Browse the repository at this point in the history
  • Loading branch information
didimitrie committed Jan 7, 2025
1 parent d51f8f3 commit 50e634c
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,17 @@ public sealed class RhinoSendBinding : ISendBinding
private readonly ISdkActivityFactory _activityFactory;

/// <summary>
/// Used internally to aggregate the changed objects' id. Note we're using a concurrent dictionary here as the expiry check method is not thread safe, and this was causing problems. See:
/// Used internally to aggregate the changed objects' id. Objects in this list will be reconverted.
///
/// Note we're using a concurrent dictionary here as the expiry check method is not thread safe, and this was causing problems. See:
/// [CNX-202: Unhandled Exception Occurred when receiving in Rhino](https://linear.app/speckle/issue/CNX-202/unhandled-exception-occurred-when-receiving-in-rhino)
/// As to why a concurrent dictionary, it's because it's the cheapest/easiest way to do so.
/// https://stackoverflow.com/questions/18922985/concurrent-hashsett-in-net-framework
/// </summary>
private ConcurrentDictionary<string, byte> ChangedObjectIds { get; set; } = new();

/// <summary>
///
/// Stores objects that have "changed" only the commit structure/proxies - they do not need to be reconverted.
/// </summary>
private ConcurrentDictionary<string, byte> ChangedObjectIdsInGroups { get; set; } = new();
private ConcurrentDictionary<int, byte> ChangedMaterialIndexes { get; set; } = new();
Expand Down

0 comments on commit 50e634c

Please sign in to comment.