Skip to content

Commit

Permalink
Update blender_commit_object_builder.py
Browse files Browse the repository at this point in the history
  • Loading branch information
JR-Morgan committed Jul 22, 2023
1 parent 8952843 commit 201ca5f
Showing 1 changed file with 1 addition and 15 deletions.
16 changes: 1 addition & 15 deletions bpy_speckle/blender_commit_object_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,20 +73,6 @@ def ensure_collection(self, col: Collection) -> SCollection:

return convered_collection

# def find_collection_parent(self, col: Collection) -> Optional[Collection]:
# for p in bpy.data.collections:
# if col.name in p.children.keys():
# return p
# return None

#TODO: I've started an approach that will not work
# Goal #1 get all collections sending
# Sync with Claire, ask how we handle this in Rhino with partial selection of layers (proably how I'm expecting it works, but good to double check)
# Goal #2 Figure out how to send collections
# - all collections
# - all collections that contain a child collection that has geometry...
# - only collections explicitly selected

def build_commit_object(self, root_commit_object: Base) -> None:
assert(root_commit_object.applicationId in self.converted)

Expand Down Expand Up @@ -131,4 +117,4 @@ def should_remove_unuseful_collection(col: SCollection) -> bool: #TODO: this may
return should_remove_this_col

if should_remove_unuseful_collection(root_commit_object):
_report("WARNING: Only empty collections have been converted!") #TODO: consider raising exception here, to halt the send operation
_report("WARNING: Only empty collections have been converted!") #TODO: consider raising exception here, to halt the send operation

0 comments on commit 201ca5f

Please sign in to comment.