Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a button to download default trees #6188

Open
wants to merge 5 commits into
base: production
Choose a base branch
from
Open

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Feb 3, 2025

Fixes #6123

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add relevant documentation (Tester - Dev)

Testing instructions

New icon introduced:
Screenshot 2025-02-03 at 11 27 28 AM

  • Open the tree viewer for Taxon
  • Verify that there is no Download New Tree icon under the first rank if the tree has nodes (other than root)
  • Verify that there is the Download New Tree icon under the + Icon (Create Root Node) in the first rank column for new empty trees
  • Verify that there is the Download New Tree icon under Root in the first rank column for trees that only have a root node
  • Verify that clicking the new icon opens https://files.specifysoftware.org/taxonfiles/ with a list of default trees to download from

TODO:

  • Add explanation in https://files.specifysoftware.org/taxonfiles/ for what to do with the dowloaded tree

@CarolineDenis CarolineDenis added this to the 7.11 milestone Feb 3, 2025
@CarolineDenis CarolineDenis requested review from a team and acwhite211 February 4, 2025 20:40
Copy link
Collaborator

@lexiclevenger lexiclevenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Open the tree viewer for Taxon
  • Verify that there is no Download New Tree icon under the first rank if the tree has nodes (other than root)
  • Verify that there is the Download New Tree icon under the + Icon (Create Root Node) in the first rank column for new empty trees
  • Verify that there is the Download New Tree icon under Root in the first rank column for trees that only have a root node
  • Verify that clicking the new icon opens https://files.specifysoftware.org/taxonfiles/ with a list of default trees to download from

Looks good! One thing I noticed--when starting from an empty tree or one with a root node, the download button stays after you add nodes until the page is refreshed. Is this acceptable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋Back Log
Development

Successfully merging this pull request may close these issues.

Add 'Populate Tree' Button to Tree Viewer
4 participants