Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide tectonic tree for non paleo or geo disciplines #5342

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Hide tectonic tree for non paleo or geo disciplines #5342

merged 1 commit into from
Oct 25, 2024
+11 −4

Conversation

CarolineDenis
Copy link
Contributor

Fixes #5334

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Verify Tectonic Tree is hidden unless the discipline is vertpaleo, invertpaleo, or geology (or any number of sub-geology disciplines we define)

@CarolineDenis CarolineDenis added this to the 7.9.8 milestone Oct 23, 2024
@CarolineDenis CarolineDenis marked this pull request as ready for review October 23, 2024 15:30
@CarolineDenis CarolineDenis requested a review from a team October 23, 2024 15:30
pashiav
pashiav approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Verify Tectonic Tree is hidden unless the discipline is vertpaleo, invertpaleo, or geology (or any number of sub-geology disciplines we define)

Looks good!! I checked a few disciplines and they're all functioning as expected.

For future testers:
If you don't know whether or not the discipline you're checking is one of the above listed in the instructions:
- Query Discipline -> add Type to the query
- ...test.specifysystems.org/specify/query/new/discipline/

@pashiav pashiav requested review from a team October 23, 2024 21:00
emenslin
emenslin approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Verify Tectonic Tree is hidden unless the discipline is vertpaleo, invertpaleo, or geology (or any number of sub-geology disciplines we define)

Looks good, it's hidden in non- paleo/geo db but visible in paleo/geo db

@emenslin emenslin requested a review from a team October 24, 2024 14:11
alesan99
alesan99 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@alesan99 alesan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Verify Tectonic Tree is hidden unless the discipline is vertpaleo, invertpaleo, or geology (or any number of sub-geology disciplines we define)

The tree is shown when appropriate and hidden otherwise for me 👍👍

@CarolineDenis CarolineDenis merged commit 0b85e8f into production Oct 25, 2024
12 checks passed
@CarolineDenis CarolineDenis deleted the issue-5334 branch October 25, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alesan99 alesan99 alesan99 approved these changes

@sharadsw sharadsw sharadsw approved these changes

@pashiav pashiav pashiav approved these changes

@emenslin emenslin emenslin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.9.8
Development

Successfully merging this pull request may close these issues.

Hide Tectonic Unit for non-paleo/geo disciplines
5 participants
@CarolineDenis @alesan99 @sharadsw @pashiav @emenslin