MOTs: Add frontend picklist for COType #5170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarolineDenis
approved these changes
Aug 1, 2024
sharadsw
changed the title
emenslin
requested changes
Aug 1, 2024
There was a problem hiding this comment.
Testing instructions
- Create a workbench dataset with base table CollectionObjectType
- Map a column to
CollectionObjectType -> name - Click save
- Verify the column you mapped is a picklist containing all CollectionObjectTypes that exist in your db
- Re-run the same test with CollectionObject as the base table and mapping a column to
CollectionObject -> CollectionObjectType -> name
Cannot actually validate the dataset if it contains collectionobjecttype
chrome_frE2kFyiiK.mp4
Also the table does not have an icon in the dataset
emenslin
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Testing instructions
- Create a workbench dataset with base table CollectionObjectType
- Map a column to
CollectionObjectType -> name - Click save
- Verify the column you mapped is a picklist containing all CollectionObjectTypes that exist in your db
- Re-run the same test with CollectionObject as the base table and mapping a column to
CollectionObject -> CollectionObjectType -> name
Looks good!
alesan99
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Testing instructions
- Create a workbench dataset with base table CollectionObjectType
- Map a column to
CollectionObjectType -> name - Click save
- Verify the column you mapped is a picklist containing all CollectionObjectTypes that exist in your db
- Re-run the same test with CollectionObject as the base table and mapping a column to
CollectionObject -> CollectionObjectType -> name
The picklist is working well on my db 👍👍
|
This pull request has been mentioned on Specify Community Forum. There might be relevant details there: https://discourse.specifysoftware.org/t/specify-7-9-7-release-announcement/1979/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5169
NOTES:
Yay more MOTsAdded a frontend picklist similar to the preptype picklist. All columns in the workbench mapped to CoType -> name should use this.
Checklist
and self-explanatory (or properly documented)
Testing instructions
CollectionObjectType -> nameCollectionObject -> CollectionObjectType -> name