Recalculate WB search function when utils changes #4936
Conversation
There was a problem hiding this comment.
Testing instructions
For a large dataset (such as FishTissueData (user spadmin, collection KUFishVoucher), and a small dataset (such as those listed in #4931 (comment)):
- Ensure the search functionality is consistent with
v7.9.4with multiple search configurations
Looks great, search function is working!
There was a problem hiding this comment.
Testing instructions
For a large dataset (such as FishTissueData (user spadmin, collection KUFishVoucher), and a small dataset (such as those listed in #4931 (comment)):
- Ensure the search functionality is consistent with
v7.9.4with multiple search configurations
Great job, search functionality works as intended!
There was a problem hiding this comment.
Testing instructions
For a large dataset (such as FishTissueData (user spadmin, collection KUFishVoucher), and a small dataset (such as those listed in #4931 (comment)):
- Ensure the search functionality is consistent with
v7.9.4with multiple search configurations
Searching works automatically, and the search configurations are respected like they are in v7.9.4 👍
As a note, there has been a change in behavior (An improvement imo)
Previously, pressing enter after typing something into the search bar would bring you directly to edit mode on the first found cell. Pressing the arrows on the hightlight buttons would then simply select the next cells (not edit)
Now, pressing enter simply selects the first found cell.
If you can get the search function to work in the original React Workbench PR, this is also the case there, so its not entirely related to this PR's changes.
Left: v7.9.4 Right: This PR
chrome_b6SzFX4wOb.mp4
|
Sorry about this, but could this be briefly tested again? Did a slight optimization change which shouldn't have changed any functionality, but worth going over once again to make sure! |
There was a problem hiding this comment.
Testing instructions
For a large dataset (such as FishTissueData (user spadmin, collection KUFishVoucher), and a small dataset (such as those listed in #4931 (comment)):
- Ensure the search functionality is consistent with
v7.9.4with multiple search configurations
Everything still looks good! I tested different search configurations, and they functioned as expected. Additionally, I was able to replicate the enter selection behavior change that @alesan99 noticed. I also agree that it's an improvement compared to the behavior in v7.9.4.
|
Another improvement here: Live search works as expected now. In |
|
This pull request has been mentioned on Specify Community Forum. There might be relevant details there: https://discourse.specifysoftware.org/t/specify-7-9-5-release-announcement/1751/1 |
Fixes #4931
Related to #4637
Checklist
and self-explanatory (or properly documented)
Testing instructions
For a large dataset (such as FishTissueData (user
spadmin, collectionKUFishVoucher), and a small dataset (such as those listed in #4931 (comment)):v7.9.4with multiple search configurations