Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct WorkBench dialog heading so 'Timestamp Modified' becomes 'Timestamp Uploaded' #4472

Merged
merged 4 commits into from
Feb 3, 2024
Merged

Correct WorkBench dialog heading so 'Timestamp Modified' becomes 'Timestamp Uploaded' #4472

merged 4 commits into from
Feb 3, 2024

Conversation

grantfitzsimmons
Copy link
Member

Fixes #4011

This essentially undoes the change @maxpatiiuk made in December 2022 (43cf24d), but instead of using commonText.uploaded, it defines a new string consistent with the 'Timestamp' nomenclature.

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone

Testing instructions

image
  1. Open the WorkBench dialog
  2. Verify that 'Timestamp Uploaded' is shown instead of 'Timestamp Created'
  3. Verify sorting works correctly

@grantfitzsimmons grantfitzsimmons added this to the 7.9.4 milestone Jan 27, 2024
@maxpatiiuk maxpatiiuk mentioned this pull request Jan 30, 2024
Closed
@grantfitzsimmons grantfitzsimmons requested a review from a team February 1, 2024 02:10
@realVinayak realVinayak requested a review from a team February 1, 2024 02:44
pashiav
pashiav approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@grantfitzsimmons grantfitzsimmons merged commit 3b4967d into production Feb 3, 2024
9 checks passed
@grantfitzsimmons grantfitzsimmons deleted the issue-4011 branch February 3, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpatiiuk maxpatiiuk maxpatiiuk approved these changes

@realVinayak realVinayak realVinayak approved these changes

@pashiav pashiav pashiav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.9.4
Development

Successfully merging this pull request may close these issues.

WorkBench Data Sets dialog shows "Timestamp Modified" instead of "Uploaded"
4 participants
@grantfitzsimmons @maxpatiiuk @realVinayak @pashiav