Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional deletion blocker from import #2807

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Conversation

melton-jason
Copy link
Contributor

I have no words on how this left over import got through with my merge from #2702.

The additional delete blockers were moved to #2806 in commit c25ab91 and were supposed to be cleaned up from #2702 in 0387638.
I am amazed this got past me, the dockerize test, and backend tests.

Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry. Not a big deal.

Unlike on the front-end, where TypeScript will throw a type error for any unused import, the back-end does not currently have any such checks (though you are welcome to configure some if you want)

@maxpatiiuk maxpatiiuk merged commit dfa98a2 into production Jan 13, 2023
@maxpatiiuk maxpatiiuk deleted the fix-import branch January 13, 2023 04:25
@melton-jason
Copy link
Contributor Author

I realize that now, unfortunately. It will not happen again and I will be more vigilant about these things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants