Don't add cursor: pointer
to var
s when variable highlighting is inactive
#4870
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In exported documents, variable highlighting is inactive, and clicking on
var
s doesn't do anything. So, I think we shouldn't setcursor: pointer
on them.This seems to possibly have been a mistake and only intended for variables with a data type hover bubble, but even there, clicking on them doesn't do anything so setting
cursor: pointer
on them still doesn't particularly make sense, IMHO.For non-exported documents when highlighting is active, src/styles/var.css.js will still set
cursor: pointer
, so this shouldn't break that case.