Makefile: Change validate-canonical-match source from '.' to 'src' #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old '.' lead to errors like:
[Fatal Error] comment.xml:5:10: An invalid XML character (Unicode: 0xe) was found in the comment.
16:10:09.437 [main] ERROR org.spdx.licensexml.LicenseXmlDocument - Error parsing license XML document
org.xml.sax.SAXParseException: An invalid XML character (Unicode: 0xe) was found in the comment.
at org.apache.xerces.parsers.DOMParser.parse(DOMParser.java:245) ~[spdx-tools-2.1.9.jar:?]
at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:298) ~[spdx-tools-2.1.9.jar:?]
at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:205) ~[?:1.8.0_151]
at org.spdx.licensexml.LicenseXmlDocument.<init>(LicenseXmlDocument.java:74) [spdx-tools-2.1.9.jar:?]
at org.spdx.licensexml.XmlLicenseProvider$XmlLicenseIterator.findNextItem(XmlLicenseProvider.java:63) [spdx-tools-2.1.9.jar:?]
at org.spdx.licensexml.XmlLicenseProvider$XmlLicenseIterator.next(XmlLicenseProvider.java:99) [spdx-tools-2.1.9.jar:?]
at org.spdx.licensexml.XmlLicenseProvider$XmlLicenseIterator.next(XmlLicenseProvider.java:48) [spdx-tools-2.1.9.jar:?]
at org.spdx.tools.LicenseRDFAGenerator.writeLicenseList(LicenseRDFAGenerator.java:478) [spdx-tools-2.1.9.jar:?]
at org.spdx.tools.LicenseRDFAGenerator.generateLicenseData(LicenseRDFAGenerator.java:309) [spdx-tools-2.1.9.jar:?]
at org.spdx.tools.LicenseRDFAGenerator.main(LicenseRDFAGenerator.java:193) [spdx-tools-2.1.9.jar:?]
at org.spdx.tools.Main.main(Main.java:49) [spdx-tools-2.1.9.jar:?]
My guess is that the tooling was walking into an already-populated
.tmp (from a previous validation run) and then choking on the XML-ish
it found there.
goneall
approved these changes
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
.lead to errors like:My guess is that the tooling was walking into an already-populated
.tmp(from a previous validation run) and then choking on the XML-ish it found there.Also change default test-data location, which should have been updated as part of 36bce3f (#593).